Forums

Unfortunately no one can be told what FluxBB is - you have to see it for yourself.

You are not logged in.

#1 2010-06-21 16:07:34

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

[Mod] Another Private Messaging / Topic System - 3.0.8

Adds functions for sending messages to people within FluxBB.

http://fluxbb.org/resources/mods/anothe … ng-system/

1inGqyORC6.png
VvdJiNNnvd.png
4jKldf2aNM.png
qwX2ZCuOtm.png

If you're experimenting problems with this mod or if you have some questions, please ask here wink

https://github.com/adaur/another-privat … ing-system

Last edited by adaur (2014-03-28 22:23:27)


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#2 2010-06-22 07:06:24

G1ntas
Member
From: Lithuanian
Registered: 2010-06-22
Posts: 1

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

link don't work

Offline

#3 2010-06-22 08:06:37

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

G1ntas wrote:

link don't work

Yes, that's true.

I'm fixing a few bugs right now, it should be ok tonight, or in a few hours smile


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#4 2010-06-22 09:51:28

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

Package updated!


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#5 2010-06-22 11:15:15

sirena
Member
From: AU
Registered: 2008-05-10
Posts: 172

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

There were I recall some XSS bugs in 1.2 versions of this mod.
Are they all fixed? smile

Offline

#6 2010-06-22 11:34:43

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

sirena wrote:

There were I recall some XSS bugs in 1.2 versions of this mod.
Are they all fixed? smile

French users use this mod since 2006, and for what I know, there is no XSS exploits in this version.

I invite you to check the changelog wink


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#7 2010-06-30 17:13:50

hussam
Member
Registered: 2010-06-13
Posts: 41

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

I installed this mod. but I had to do some minor modifications to it.

Offline

#8 2010-06-30 17:17:50

Franz
Lead developer
From: Germany
Registered: 2008-05-13
Posts: 6,626
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

To work with 1.4? Could you post what you had to do exactly?


fluxbb.de | develoPHP

"As code is more often read than written it's really important to write clean code."

Offline

#9 2010-06-30 17:48:32

hussam
Member
Registered: 2010-06-13
Posts: 41

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

I'll try to remember but in step 34 
<?php endif;   
should be
<?php endif; ?>
The translations needed some updating too.

Also in the file AP_Private_messaging.php

define('PLUGIN_URL', 'admin_loader.php?plugin=AP_Private_Messaging.php');
needs to be changed to
define('PLUGIN_URL', 'admin_loader.php?plugin=AP_Private_messaging.php');

I have a diff to git. I can send it to you but it contains other modifications too.

Offline

#10 2010-07-16 15:02:26

disco
Member
Registered: 2010-06-09
Posts: 15

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

Hey, does this mod have the ability to put new / unread messages in bold for example? (or have a different icon in front of unread messages) - I'm using the simple "private message' mod now and this feature is missing and i'd like to change it for something better..

How is this one different?

Thanks for your work anyway smile

Offline

#11 2010-07-18 16:22:21

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

Hi

@hussam : fixed, thanks. I'd like to see the others modifications, if it's not a pb for you!

@disco : yeah, this feature is present (new messages in bold, the existent system has been improved for Flux 1.4. The image used to show new messages in viewforum will be used in the pms_list too.)

Except the install_mod dirty (I'll fix it when I'll have more time), there is only minors issues remaining, I think...

Last edited by adaur (2010-07-18 16:22:42)


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#12 2010-07-19 06:20:27

hussam
Member
Registered: 2010-06-13
Posts: 41

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

adaur wrote:

@hussam : fixed, thanks. I'd like to see the others modifications, if it's not a pb for you!

Will a diff to git work as well? I have other mods installed too and I can't tell anymore which change belongs to which mod. Where do I send it?

Offline

#13 2010-07-23 05:08:36

Starcom
Member
Registered: 2009-01-07
Posts: 9

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

I need this mod, but where is it ?

Last edited by Starcom (2010-07-23 05:09:24)

Offline

#14 2010-07-23 07:58:53

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

hussam wrote:
adaur wrote:

@hussam : fixed, thanks. I'd like to see the others modifications, if it's not a pb for you!

Will a diff to git work as well? I have other mods installed too and I can't tell anymore which change belongs to which mod. Where do I send it?

Well, no pb, do not bother you to search the modifications, I think they are all fixed wink.

Starcom wrote:

I need this mod, but where is it ?

Under review, again and again tongue. And I have to update the modifications for profile.php, because of FluxBB 1.4.1 tongue.


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#15 2010-07-23 11:13:08

hussam
Member
Registered: 2010-06-13
Posts: 41

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

If I have the old revision installed, do I need to revert it and install the new one when it's reviewed?

Offline

#16 2010-07-23 14:02:58

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

hussam wrote:

If I have the old revision installed, do I need to revert it and install the new one when it's reviewed?

The mod is now accepted; to update your version, just replace all your old files by the new one, and change the caracters in the database from ISO-8859-1 (iso swedish...) to UTF-8 (utf8_general_ci ...) wink.

Last edited by adaur (2010-07-23 14:03:12)


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#17 2010-07-23 14:24:25

hussam
Member
Registered: 2010-06-13
Posts: 41

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

It's not listed under http://fluxbb.org/resources/mods/?s=key … all&o=date

nevermind, found it

Last edited by hussam (2010-07-23 14:27:16)

Offline

#18 2010-07-23 14:42:53

hussam
Member
Registered: 2010-06-13
Posts: 41

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

adaur wrote:

change the caracters in the database from ISO-8859-1 (iso swedish...) to UTF-8 (utf8_general_ci ...) wink.

how do I do that?

Offline

#19 2010-07-23 14:48:01

Otomatic
FluxBB Donor
From: Paris - France
Registered: 2010-01-26
Posts: 567
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

Hello,

If the table is MySQL, do a query with PhpMyAdmin :

ALTER TABLE `prefix_my_table` CONVERT TO CHARSET utf8 COLLATE utf8_general_ci;

Ce n'est pas parce que l'erreur se propage qu'elle devient vérité. Ghandi
An error does not become truth by reason of multiplied propagation. Ghandi

Offline

#20 2010-07-23 14:53:50

hussam
Member
Registered: 2010-06-13
Posts: 41

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

Otomatic wrote:

Hello,

If the table is MySQL, do a query with PhpMyAdmin :

ALTER TABLE `prefix_my_table` CONVERT TO CHARSET utf8 COLLATE utf8_general_ci;

Thank you very much smile

Offline

#21 2010-07-26 14:27:02

daris
Developer
From: Poland
Registered: 2008-05-09
Posts: 557

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

1. When you do steps from readme before installing mod, you'll not able to install mod (shows error that table messages doesn't exist, include/functions.php, line 38)
2. pms_send.php line 374 and 376 - no close tag for "label"
3. pms_send.php line 147 - if tpl not exists in user language then it shows and error while sending message (add callback to english)
3. Use english variable names (what does $p_destinataire mean?)

Feature request:
Add Quick reply form to message view (copy from viewtopic.php tongue )

edit:
4. pms_list.php line 118 - it sould be ?box=0
5. pms_list.php line 446 - use onclick="checkAll" instead of onclick="javascript:checkAll"

Last edited by daris (2010-07-26 14:45:54)

Offline

#22 2010-07-29 14:47:31

Visman
Member
From: Siberia
Registered: 2010-07-10
Posts: 1,196
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

$idlist = implode(',', array_values($_POST['selected_messages']));
        
$db->query('... ... WHERE id IN ('.$idlist .') AND owner=...
$db->query('DELETE FROM '.$db->prefix.'messages WHERE id IN ('.$_POST['messages'] .')...

It is vulnerability!?

Offline

#23 2010-07-29 16:11:39

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

You're right, that's a security hole.

Edit: the exploit is harder to fix than I thought. If you know how to fix it... please tell me smile !

I'm going to fix it asap!

@daris : I'm taking notes to fix these bugs. Thanks!

Last edited by adaur (2010-07-29 17:33:32)


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#24 2010-07-30 05:20:48

Smartys
Former Developer
Registered: 2008-04-27
Posts: 3,139
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

It's actually not hard at all. When you have the results as an array, you use array_map with intval as the callback function. Then you can implode without fear. smile

Offline

#25 2010-07-30 10:38:07

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 842
Website

Re: [Mod] Another Private Messaging / Topic System - 3.0.8

I just uploaded the update. Please, accept it quickly =/.

Thanks to Visman, daris, and Smartys btw!


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

Board footer

Powered by FluxBB