Forums

Unfortunately no one can be told what FluxBB is - you have to see it for yourself.

You are not logged in.

#1 2010-12-08 19:53:33

Franz
Lead developer
From: Germany
Registered: 2008-05-13
Posts: 6,661
Website

Translators, get ready for v1.4.3

We're turning around the corner for the 1.4.3 release.

This will be a rather big relese and requires some updates to the language files.

With the translation of the install and update scripts the FluxBB core is now fully translateable.
Besides that, there are a few minor changes in some of the other files.

You can see all the changes starting here: https://github.com/fluxbb/fluxbb/compar … er#diff-39 (takes a while, mind you).


fluxbb.de | develoPHP

"As code is more often read than written it's really important to write clean code."

Online

#2 2010-12-09 12:14:12

jojaba
Member
From: Obersoultzbach, Elsaß, France
Registered: 2009-12-04
Posts: 473
Website

Re: Translators, get ready for v1.4.3

Franz wrote:

You can see all the changes starting here: https://github.com/fluxbb/fluxbb/compar … er#diff-39 (takes a while, mind you).

Oh, that is exactly what I wanted to do yesterday, but didn't find out how to do this (I mean comparing 1.4.2 with 1.4.3). Could you please tell me how I should proceed to do a comparison on github? (I don't remember if I already asked this hmm ).
Is it possible to display only the differences in the language folder ?

Thanks in advance smile

Last edited by jojaba (2010-12-09 12:14:46)


Localize Mozilla extensions on BabelZilla

Offline

#3 2010-12-09 12:25:49

Reines
Administrator
From: Scotland
Registered: 2008-05-11
Posts: 3,197
Website

Re: Translators, get ready for v1.4.3

I'm not quite sure where the link on GitHub is, but the URL is https://github.com/fluxbb/fluxbb/compare/. It will ask you for a start point (i.e. the tag name, fluxbb-1.4.2) and automatically compare it to the master - though you can then click on master on the top right and change that to another tag if you wish (i.e. fluxbb-1.4.3, once we tag it).

I don't think there is an easy way to restrict it to just language files unfortunately, though it does at least group them together since they are in the same folder.

Offline

#4 2010-12-09 12:50:15

Pierre
Member
From: Germany/Bonn
Registered: 2010-05-20
Posts: 50
Website

Re: Translators, get ready for v1.4.3

Just use this to see only the changes made in the lang subfolder:

git diff --relative=lang fluxbb-1.4.2 master

Last edited by Pierre (2010-12-09 12:50:52)

Offline

#5 2010-12-09 12:54:47

Franz
Lead developer
From: Germany
Registered: 2008-05-13
Posts: 6,661
Website

Re: Translators, get ready for v1.4.3

On the branch list page, you can compare branches directly by clicking a button.
As Jamie said, you can then use other names (of branches, tags and commits) for comparison directly in the URL.

I had the same question you did regarding comparing only subpaths and asked it on #github on IRC yesterday, but there's currently no way to do that. I'll add a GitHub ticket later.

More info in this GitHub blog entry.


fluxbb.de | develoPHP

"As code is more often read than written it's really important to write clean code."

Online

#6 2010-12-09 13:45:52

Reines
Administrator
From: Scotland
Registered: 2008-05-11
Posts: 3,197
Website

Re: Translators, get ready for v1.4.3

Pierre wrote:

Just use this to see only the changes made in the lang subfolder:

git diff --relative=lang fluxbb-1.4.2 master

Cheers smile

Offline

#7 2010-12-09 15:57:19

jojaba
Member
From: Obersoultzbach, Elsaß, France
Registered: 2009-12-04
Posts: 473
Website

Re: Translators, get ready for v1.4.3

Pierre wrote:

Just use this to see only the changes made in the lang subfolder:

git diff --relative=lang fluxbb-1.4.2 master

I'm looking for a solution directly on the github site, so this command shouldn't help me I guess. Still thank you for that wink
The comparison can also be done localy, I will surely do it such way. Can I begin with translation (I think about the 2 big new files install.php and update.php) ? Or are some other strings (in this 2 files) planed to be added ?
[edit]
I saw here : https://github.com/fluxbb/fluxbb/compar … 4...master that the developpment version is 1.4.4. Shouldn't it be 1.4.3 ?
[/edit]

Last edited by jojaba (2010-12-09 16:01:49)


Localize Mozilla extensions on BabelZilla

Offline

#8 2010-12-09 16:05:04

Franz
Lead developer
From: Germany
Registered: 2008-05-13
Posts: 6,661
Website

Re: Translators, get ready for v1.4.3

jojaba wrote:

Can I begin with translation (I think about the 2 big new files install.php and update.php) ? Or are some other strings (in this 2 files) planed to be added ?

That's why I started this topic. Please start. No more changes to language files are planned.

jojaba wrote:

I saw here : https://github.com/fluxbb/fluxbb/compar … 4...master that the developpment version is 1.4.4. Shouldn't it be 1.4.3 ?

Nope, I was already working on some tickets for our next version, which will be 1.4.4.


fluxbb.de | develoPHP

"As code is more often read than written it's really important to write clean code."

Online

#9 2010-12-09 16:44:58

jojaba
Member
From: Obersoultzbach, Elsaß, France
Registered: 2009-12-04
Posts: 473
Website

Re: Translators, get ready for v1.4.3

Franz wrote:
jojaba wrote:

Can I begin with translation (I think about the 2 big new files install.php and update.php) ? Or are some other strings (in this 2 files) planed to be added ?

That's why I started this topic. Please start. No more changes to language files are planned.

OK, let's begin wink


Localize Mozilla extensions on BabelZilla

Offline

#10 2010-12-09 20:14:45

Plazzmex
Member
Registered: 2008-07-24
Posts: 85

Re: Translators, get ready for v1.4.3

Wow.. I'm starting right now..

Offline

#11 2010-12-10 09:01:30

jojaba
Member
From: Obersoultzbach, Elsaß, France
Registered: 2009-12-04
Posts: 473
Website

Re: Translators, get ready for v1.4.3

In the /lang/English/update.php file on line 29, <i> and </i> should be replaced by <em> and </em>

In the /lang/English/install.php file the 2 following lines are a little confusing :

'Administrator password 1'        =>    'Administrator password 1',
'Administrator password 2'        =>    'Administrator password 2',

It seems you must enter 2 different passwords, wich is not the case I guess. I would respell it so :

'Administrator password 1'        =>    'Administrator password',
'Administrator password 2'        =>    'Administrator password again',

Last edited by jojaba (2010-12-10 10:56:16)


Localize Mozilla extensions on BabelZilla

Offline

#12 2010-12-10 13:26:48

Franz
Lead developer
From: Germany
Registered: 2008-05-13
Posts: 6,661
Website

Re: Translators, get ready for v1.4.3

Translators, one more change, though slightly less important, since it is a simple removal:
http://fluxbb.org/development/core/tick … kw18e9wgfd

-------------

I just replaced <i> with <em>. Thank you.

What about "Confirm administrator password"? That would be a little more consistent with other password fields.
Let's leave this one for Jamie, since he's fixing some things in that script.

Last edited by Franz (2010-12-10 13:27:08)


fluxbb.de | develoPHP

"As code is more often read than written it's really important to write clean code."

Online

#13 2010-12-10 14:03:35

Plazzmex
Member
Registered: 2008-07-24
Posts: 85

Re: Translators, get ready for v1.4.3

Some problems I found out when translating:

1. The 'You are running error' in install.php isn't influenced by RTL (BiDi), so it looks ugly when translated to Hebrew. (may be there are some other errors too that looks the same, didn't check all of them)

2. The first page where I choose the install language, when it is displayed in RTL it is aligned to right, but the install page itself is aligned to left with rtl language.
Why ?

Offline

#14 2010-12-10 14:28:11

jojaba
Member
From: Obersoultzbach, Elsaß, France
Registered: 2009-12-04
Posts: 473
Website

Re: Translators, get ready for v1.4.3

Franz wrote:

What about "Confirm administrator password"? That would be a little more consistent with other password fields.

Yes it's better smile


Localize Mozilla extensions on BabelZilla

Offline

#15 2010-12-10 15:54:40

Mpok
Member
From: France
Registered: 2008-05-12
Posts: 389

Re: Translators, get ready for v1.4.3

Thks jojaba (once more wink) for your involvement.
Your package will be copied/published on fluxbb.fr for download as soon it is available.
And maybe before we migrate ourselves in 1.4.3, cos "end-of-the-year" process is somehow more important than migration.

(@devs: which means, either you do the update these early days, either you do it after Jan. 1… tongue NOT on holidays…).

Offline

#16 2010-12-10 15:58:50

Mpok
Member
From: France
Registered: 2008-05-12
Posts: 389

Re: Translators, get ready for v1.4.3

Thks jojaba (once more wink) for your involvement.
Your package will be copied/published on fluxbb.fr for download as soon it is available.
And maybe before we migrate ourselves in 1.4.3, cos "end-of-the-year" process is somehow more important than a migration.

@devs: which means, either you release the update these early days, either you do it after Jan. 3… tongue
But NOT on holidays, please… wink

Offline

#17 2010-12-10 17:19:34

adaur
Developer
From: France
Registered: 2010-01-07
Posts: 843
Website

Re: Translators, get ready for v1.4.3

Is it so important to update for fluxbb.fr? As the update does'nt fix any security issues, I don't see why you don't want the devs to release it during holidays tongue


FeatherBB - A simple and lightweight new generation forum system
Based on FluxBB, written in PHP, using Slim Framework for a proper OOP-MVC architecture.

Offline

#18 2010-12-11 01:01:27

jojaba
Member
From: Obersoultzbach, Elsaß, France
Registered: 2009-12-04
Posts: 473
Website

Re: Translators, get ready for v1.4.3

I tried to test my french pakage for 1.4.3 version but I don't know how to set the installation page to French (it is displayed in english although I put the French folder into the lang directory).
For the moment I manually changed a 2 strings in the install.php file to have the French translation displayed ("English" has been replaced by "French" in the code below) :

<?php

/**
 * Copyright (C) 2008-2010 FluxBB
 * based on code by Rickard Andersson copyright (C) 2002-2008 PunBB
 * License: [url]http://www.gnu.org/licenses/gpl.html[/url] GPL version 2 or higher
 */

// The FluxBB version this script installs
define('FORUM_VERSION', '1.4.2');

define('FORUM_DB_REVISION', 10);
define('FORUM_SI_REVISION', 1);
define('FORUM_PARSER_REVISION', 1);

define('MIN_PHP_VERSION', '4.3.0');
define('MIN_MYSQL_VERSION', '4.1.2');
define('MIN_PGSQL_VERSION', '7.0.0');
define('PUN_SEARCH_MIN_WORD', 3);
define('PUN_SEARCH_MAX_WORD', 20);


define('PUN_ROOT', dirname(__FILE__).'/');

// If we've been passed a default language, use it
$default_lang = isset($_POST['req_default_lang']) ? trim($_POST['req_default_lang']) : 'French';

// If such a language pack doesn't exist, or isn't up-to-date enough to translate this page, default to English
if (!file_exists(PUN_ROOT.'lang/'.$default_lang.'/install.php'))
    $default_lang = 'French';

require PUN_ROOT.'lang/'.$default_lang.'/install.php';

After the installation (I set as default language the French pakage) when going to the administration pane, all was in English yikes ! There is surely a problem with taking the default language in account...

Thanks in advance

PS : did you noticed that the forum version is still defined to 1.4.2 ?

// The FluxBB version this script installs
define('FORUM_VERSION', '1.4.2');

Should be changed wink

[edit]
I understood what happens about the administration pane and also the rest of the forums, I forget to change the default language in my profile (I don't remember if I was asked for this while I installed fluxbb).
[/edit]

Last edited by jojaba (2010-12-11 01:18:39)


Localize Mozilla extensions on BabelZilla

Offline

#19 2010-12-11 10:06:36

Reines
Administrator
From: Scotland
Registered: 2008-05-11
Posts: 3,197
Website

Re: Translators, get ready for v1.4.3

jojaba wrote:

I tried to test my french pakage for 1.4.3 version but I don't know how to set the installation page to French (it is displayed in english although I put the French folder into the lang directory).

If you go straight to install.php it'll default to English. If you try browse any other page where it previously said "bla bla you need to install", it now also displays an option to choose the language for the install page.

jojaba wrote:

After the installation (I set as default language the French pakage) when going to the administration pane, all was in English yikes ! There is surely a problem with taking the default language in account...

Will check it, cheers.

jojaba wrote:

PS : did you noticed that the forum version is still defined to 1.4.2 ?

Yeah, we haven't tagged the 1.4.3 release yet as I still have a ticket to finish but as usual haven't got around to it yet...

Offline

#20 2010-12-11 12:11:41

zaher
Member
From: Damascus, Syria
Registered: 2008-07-12
Posts: 126
Website

Re: Translators, get ready for v1.4.3

Arabic language pack is updated.
38aa179

Offline

#21 2010-12-11 12:17:32

Reines
Administrator
From: Scotland
Registered: 2008-05-11
Posts: 3,197
Website

Re: Translators, get ready for v1.4.3

The install file there look rather strange, are you sure it is saved as UTF-8 and not something else?

Offline

#22 2010-12-11 12:38:51

zaher
Member
From: Damascus, Syria
Registered: 2008-07-12
Posts: 126
Website

Re: Translators, get ready for v1.4.3

install.php Fixed Thanks smile

Offline

#23 2010-12-11 12:41:24

Reines
Administrator
From: Scotland
Registered: 2008-05-11
Posts: 3,197
Website

Re: Translators, get ready for v1.4.3

Looks good, cheers smile

Offline

#24 2010-12-11 13:55:02

jojaba
Member
From: Obersoultzbach, Elsaß, France
Registered: 2009-12-04
Posts: 473
Website

Re: Translators, get ready for v1.4.3

Reines wrote:
jojaba wrote:

I tried to test my french pakage for 1.4.3 version but I don't know how to set the installation page to French (it is displayed in english although I put the French folder into the lang directory).

If you go straight to install.php it'll default to English. If you try browse any other page where it previously said "bla bla you need to install", it now also displays an option to choose the language for the install page.

Ah bon ? Why not provide a way to have the install page translated when you go directly to it ? For example, first ask the administrator wich language he wants to use to install and set up his forum, then display the translated install page.

I give you a link to my test pakage so you can try it out yourself wink
http://code.google.com/p/jojaba-code/do … xBB143.zip


Localize Mozilla extensions on BabelZilla

Offline

#25 2010-12-15 23:30:32

Franz
Lead developer
From: Germany
Registered: 2008-05-13
Posts: 6,661
Website

Re: Translators, get ready for v1.4.3

And one more tiny change (only one string): https://github.com/fluxbb/fluxbb/commit … ef475dd2f8

Sorry about that, folks. I really hope this was the last one.


fluxbb.de | develoPHP

"As code is more often read than written it's really important to write clean code."

Online

Board footer

Powered by FluxBB