Subscribe 2

Ticket #722 (open enhancement)

Combine icons into sprites

  • Created: 2012-08-07 22:16:01
  • Reported by: Franz
  • Assigned to: Studio384
  • Milestone: 2.3
  • Component: styling
  • Priority: normal

As suggested in the forums, we should combine all icon images into one sprite in order to minimize server requests.

History

Studio384 2012-09-12 16:58:47

Can I help on any way with this? Since I don't know which icons are needed in the sprite. But I can make it if somebody can give me al the used icons.

Studio384 2012-10-09 16:56:22

  • Owner set to Studio384.

Studio384 2012-10-09 18:27:14

Any need to add all the flags to the sprite? Or made another file for all flags? Or just leave it like it is now?

I prefer that last one for the flags.

Franz 2012-10-09 21:53:52

Yeah, I don't think we need the flags in there.

Studio384 2012-10-10 17:07:44

Maybe give the flags a seperate file?

By the way, is it alright if I first put up the sprite (without realy using it) so I can test it easily (with developer tools)? It's gonna be the first time I go work seriously with sprites (I've did it before, but on a much lowwer scale).

Franz 2012-10-10 21:38:26

Sure. Did you get the site up locally? Else I can help you with that (send you a database schema, basically), makes development easier. smile

Studio384 2012-10-11 14:09:44

No, I didn't, I would like if you will do that for me! smile

Studio384 2012-11-17 14:38:55

  • Owner Studio384 removed.

Studio384 2013-05-29 12:20:41

  • Owner set to Studio384.

Mmm, can't remember that I remover myself from this ticket...

Comment edited 1 times (Diff)

Studio384 2013-10-09 19:02:55

So, the tracker is now partial moved to use sprites. Of course, you might have to hit the F5 button to see the change (not that you will see anything change or so...). Anyway, I keep the older images on the server until the works on this ticket are done.

Studio384 2013-10-10 16:35:57

So, I've good news and I've bad news. The good news is, that it does work for desktop and other large screen devices, the bad news is that it doesn't work properly on mobile devices. This is because the website isn't made for that. This issue appears only in the trackers timeline, other icons are possible to replace. It requires some serious changes in the timelines code to make this work properly for the timeline to. I'm planning to revert all changes I did to the timeline, and move on with all other icons. I'll see later what I can do with this.

Studio384 2013-10-10 17:35:05

Update: when tickets titles are longer than 1 line, this fails too, reverted.