Ticket #977 (fixed enhancement)
Some hardcoded strings in views
- Created: 2014-06-15 16:42:10
- Reported by: tamplan
- Assigned to: None
- Milestone: 2.0-alpha2
- Component: code
- Priority: normal
I have change all hardcoded strings in the profile user views and made a pull request here : hxxps://github.com/fluxbb/core/pull/27
Franz 2014-06-15 19:11:48
- Component set to code.
- Milestone set to 2.0-alpha2.
- Status changed from open to fixed.
No need for extra tickets when you create pull requests like this. Unless there's some time before you actually submit a pull request.
tamplan 2014-06-15 19:27:44
I have misunderstood the documention :
Pull requests are welcome. Please open issues at our official bug tracker."
I have just understood that the bug tracker is here and not on github :-)
Franz 2014-06-15 20:03:11
Yes, the bug tracker is here, but for simple fixes like this that you submit, we don't need an extra issue.
Anyway, thanks for contributing!
tamplan 2014-06-15 20:21:42
Thanks for this information.