Fork me on GitHub
Subscribe 4

Ticket #951 (fixed bug)

[url][img] patch doesn't work.

  • Created: 2014-02-13 21:21:35
  • Reported by: GeonoTRON2000
  • Assigned to: quy
  • Milestone: 1.5.8
  • Component: parser
  • Priority: normal
[url][img]http://example.com/picture.jpg[/img][/url]

Outputs:

<a href="http://<span%20class=postimg><img%20src=http://example.com/picture.jpg%20alt=picture.jpg%20/></span>" rel="nofollow">&lt;span class=&quot;postimg&quot;&gt;&lt;img src=&quot;http:// …&#160; /&gt;&lt;/span&gt;</a>

The intended result is:

<a href="http://example.com/picture.jpg" rel="nofollow"><span class="postimg"><img src="http://example.com/picture.jpg" alt="example.jpg" /></span></a>

History

GeonoTRON2000 2014-02-13 21:27:45

  • Description changed. (Diff)
  • Uploaded patch parser.patch. (view)

Sorry if I did this wrong, I'm new to the bug reporting system.

Studio384 2014-02-13 21:34:20

Did I miss something? Where is this about?

GeonoTRON2000 2014-02-13 21:52:42

  • Description changed. (Diff)

I've tried this bug on two sites running FluxBB 1.5.6 and one site running FluxBB 1.5.4, all with the same results. The bug appears on line 667 of include/parser.php.

Franz 2014-02-13 22:11:28

  • Milestone set to 1.5.7.

GeonoTRON2000 2014-02-14 04:44:07

I tested again with the default PHP settings just to be sure (PHP5) and the bug still appears. Perhaps the double-parsing glitch was fixed in PHP?

Franz 2014-02-14 10:40:28

Does it work with three slashes for you?

quy 2014-02-14 16:49:14

3 and 4 slashes work only when an url is specified.
1 and 2 slashes work with and without an url specified.

GeonoTRON2000 2014-02-14 19:54:31

Yes. This was meant to patch when a URL is not specified, so 1 or 2 slashes is the solution.

quy 2014-02-14 21:11:38

This got affected in v1.5.4 with this ticket: "Avoid preg_replace() with PREG_REPLACE_EVAL". The simple solution is to use 1 slash.

GeonoTRON2000 2014-02-15 04:50:46

See the patch file in the first reply.

quy 2014-02-15 19:54:40

Commit d8dc875 to fluxbb master

#951: Fix regex for [url][img]. Thanks GeonoTRON2000 for patch.

quy 2014-02-15 19:59:15

  • Owner set to quy.
  • Status changed from open to fixed.

Thanks!

Franz 2014-10-20 11:51:14

  • Milestone changed from 1.5.7 to 1.5.8.