Fork me on GitHub
Subscribe 3

Ticket #947 (fixed enhancement)

Improve Air/Earth/Fire design

  • Created: 2014-02-04 18:27:43
  • Reported by: Studio384
  • Assigned to: Studio384
  • Milestone: 1.5.8
  • Component: styling
  • Priority: normal

So yes, time to update those styles a bit. Just 2 small points we should address, more ideas are allowed when discussed (in this ticket).

- Set a max-width. These days, displayes have very wide resolutions, and it is highly annoying to read 1 alinea on just 1 line of text.
- Remove images in favor of border-radius. Since over 80% of the currently used browsers do support this (IE8 is the only exceptation, and with XP going down, this should take to long), it is acceptable to make our package size smaller by removing images that are used for stuff we can do with 1 simple line of CSS.

History

Franz 2014-02-04 20:33:35

What do you think would be a nice max-width? I kinda like the 900px on our forums, but I'm sure there might be other opinions...

border-radius: Absolutely.

Studio384 2014-02-04 20:43:45

I think 960px is currenlty a normal format for websites.

Franz 2014-02-04 20:48:16

Well, yes, it should be possible to fill maybe 95% of the screen, up to a certain amount of pixels. The question is what that limit should be. With regards to readability, it probably shouldn't be much more than 1000 pixels (although the posts obviously don't span the full width).

Franz 2014-02-13 12:51:56

  • Owner changed from Studio384 to Askelon.

Charlie already comitted that as part of his recent pull request.

I hope that's okay, Yannick.

Studio384 2014-02-13 16:09:08

Not realy okay, when I take a look at his pull request, he's going to break a lot of the existing styles.

Franz 2014-02-13 16:34:32

Huh? How so? He added exactly the improvements that you mentioned in this ticket...

Studio384 2014-02-13 18:13:04

But I didn't mention to remove top-box and end-box in the templates, lots of styles still use that. That the default styles won't use those divs anymore, doesn't mean they have to go.

Also, I wanted to take this ticket as opportunity to clean up all tpl files, they are a mess. Can I do that in another ticket?

Comment edited 2 times (Diff, Diff 2)

Franz 2014-02-13 21:52:09

Yeah, I guess we can do that.

What do you want to clean up?

Askelon 2014-02-20 08:54:40

I did notice this might break some old themes but I ended up asking: who care's? In the end it is the responsibility of the styles creators to follow up on FluxBB changes and adapt their themes, we can't (and probably shouldn't) support for every existing style out there, especially when the author didn't update it. I see the point since the most productive authors are 123 and Studio384, but still, when we add/remove/edit some FluxBB parts we can't expect it to match every Mod or Plugin; I tend to think the same about the styles.

Plus, it's just removing a few useless DIVs, and styles can have their own templates, right?

Franz 2014-02-20 09:18:42

It's simple enough in this case, though. I don't want something like this to keep people from updating.

Studio384 2014-02-20 10:07:21

Removing a div that is used by almost all styles because the FluxBB core itself doesn't use it anymore is not very user friendly in my opinion. We're going to break stuff because we don't use it ourselfs. In fact, there should be a class or ID name for everything to make it more easy for developers to create new styles.

Anyway, on the templates: I think that they are hard to read because there is no use of tabs, there is code that is completely pointless (there is a part that just says <div></div>, a div without a class inside another div (both their content is the same), is useless.

Studio384 2014-02-20 10:12:44

  • Owner changed from Askelon to Studio384.

Let me reclaim my ticket...

Franz 2014-02-20 10:21:08

Which divs are you talking about? I trust Paul had a reason for every single byte. smile

Regarding indentation: I think the idea is to have as little as possible indentation, because the most important parts (content) are indented. It would also look strange in the final HTML output (that's what this is done for) as our content does not know how far the surrounding tag is indented in the template.

Askelon 2014-02-20 10:36:37

No problem with the ownership, I never claimed the ticket.

Could you name a few styles that will be really impacted by the removal of these divs? Because I browsed through the list of FluxBB Styles and most of the styles here and here, for instance. I couldn't find a single style were removing the corner divs caused anything to fall apart.

123 2014-08-22 12:47:55

More templates in HTML. Not in php. Do I update several motives. It's not a problem. Anything was better code. I miss the view template post and profile settings. Before you go out 2 expression of two years. I've thought about this a long time. Issue should be intermediate between 1.5 and 2 proposed move of the templates tpl. Make mobile version. Add a spoiler. Scaling images in signatures.There is no bbcode buttons. It's a small change, but it's important. Would spend so FluxBB 1.6. The PM will not mention because it should be. But for now, bbcode, spoiler, signature. That's the minimum. Transition piece version.

Studio384 2014-09-22 20:20:53

Commit e021a28 to fluxbb master

#947 Update styles with less width and better performance

Studio384 2014-09-22 20:21:11

Commit 73ba109 to fluxbb master

#947 Remove divs

Franz 2014-09-23 09:06:58

Commit b57da07 to fluxbb master

Merge pull request #117 from Studio384/master

#947 Update styles

Studio384 2014-09-23 14:48:23

  • Status changed from open to fixed.

Franz 2014-10-20 11:51:03

  • Milestone changed from 1.5.7 to 1.5.8.