Fork me on GitHub
Subscribe 4

Ticket #902 (fixed enhancement)

Miscellaneous

  • Created: 2013-09-23 17:01:12
  • Reported by: Koos
  • Assigned to: Franz
  • Milestone: 1.5.5
  • Component: code
  • Priority: normal

See patch.

History

Koos 2013-09-23 17:02:14

  • Uploaded patch 01_patch.patch. (view)

Studio384 2013-09-23 19:19:21

Why did you remove punctuation marks in the language files?

Franz 2013-11-13 23:34:52

  • Component set to code.
  • Milestone set to 1.5.5.
  • Type changed from bug to enhancement.

Franz 2013-11-13 23:56:12

Commit 42ac984 to fluxbb master

#902: Fix typos in language files. Thanks, Koos.

Franz 2013-11-13 23:56:52

Commit cdb70da to fluxbb master

#902: Use more effective check for invalid value. Thanks, Koos.

Franz 2013-11-13 23:59:06

  • Owner set to Franz.

I didn't merge all the changes to periods in order to keep the changes small.

Why did you consider these necessary, I'm curious?

Thanks for the patch, anyways. smile

Franz 2013-11-13 23:59:19

  • Status changed from open to fixed.

Koos 2014-03-20 20:52:36

Franz wrote:

I didn't merge all the changes to periods in order to keep the changes small.

Why did you consider these necessary, I'm curious?

Because FluxBB's error function already adds a full stop to the end of the error message. See the following for my suggestion:
https://github.com/Koos10/fluxbb/commit … 6e4ee5632f

Franz 2014-03-21 22:37:35

Ah, cool. Can you send a pull request with just these changes?

Koos 2014-03-24 21:40:44

  • Uploaded patch remove_periods_patch.patch. (view)

My FluxBB repository at GitHub isn't a fork, so I cannot create a pull request, but you can use the attached patch instead.

Comment edited 1 times (Diff)

Franz 2014-05-14 19:12:54

@Koos: To be honest, I don't think this adds real benefit, but instead will just cause more work for our translators (and look weird if they don't).