Fork me on GitHub
Subscribe 3

Ticket #757 (fixed enhancement)

pun_include: Allow files from subdirectories

  • Created: 2012-10-26 11:58:55
  • Reported by: Franz
  • Assigned to: adaur
  • Milestone: 1.5.1
  • Component: templates
  • Priority: normal

As suggested in this topic, it would be cool to organize user include files into subdirectories.

We need to be careful, though. Right now, slashes are simply not allowed as a security measure. We have to be sure to not allow directory traversal. I'll have to research whether just disallowing dots is enough.

History

adaur 2012-10-28 15:16:26

PHP function pathinfo might be more appropriate for this.

I played a little bit with it: https://github.com/fluxbb/fluxbb/pull/57

Comment edited 1 times (Diff)

adaur 2012-10-28 16:45:17

Commit 6de8f79 to fluxbb master

#757: pun_include: Allow files from subdirectories

adaur 2012-10-28 16:45:53

Commit 47beb02 to fluxbb master

#757: pun_include: Allow files from subdirectories

JohnLewis 2012-10-28 18:53:29

  • Owner set to adaur.

Since you submitted a pull request, I assume that means you want to take this on. Assign it yourself next time.

Franz 2012-10-31 11:00:16

Commit 72bdd3b to fluxbb master

Merge pull request #57 from adaur/master

#757: pun_include: Allow files from subdirectories

adaur 2012-10-31 11:02:07

  • Status changed from open to fixed.

Should be good. Feel free to test the changes wink