Fork me on GitHub
Subscribe 4

Ticket #719 (fixed bug)

Big checkbox in search.php

  • Created: 2012-08-05 18:20:59
  • Reported by: Studio384
  • Assigned to: Paul
  • Milestone: 1.5.1
  • Component: search
  • Priority: low

Another minute, another ticket...

I know that Windows 8 and Internet Explorer 10 are optimelized for use with touchscreens. Well, at the search forum. We've got a very big checkbox:

http://www.imgdumper.nl/uploads5/501eb8 … 36-bug.PNG

Al the other checkboxes are just fine. It's only that one, for so far I know. I'm using Internet Explorer 10.0.9200 (IE10 RTM).

History

Franz 2012-08-05 18:22:24

  • Milestone set to 1.5.1.
  • Owner set to Paul.

Interesting. Paul, any ideas?

Paul 2012-08-05 19:43:25

The problem is the markup does not look like FluxBB markup at all.  I certainly don't remember writing it unless it was for PunBB 1.3.  Accordingly the fix is a markup fix not a css fix to make the markup for checkboxes consistent with the rest of FluxBB.

This should work starting at line 806 of search.php

if ($pun_config['o_search_all_forums'] == '1' || $pun_user['is_admmod'])
{
	echo "\t\t\t\t\t\t".'<div class="conl multiselect">'.$lang_search['Forum search']."\n";
	echo "\t\t\t\t\t\t".'<br />'."\n";
	echo "\t\t\t\t\t\t".'<div class="checklist">'."\n";

	$cur_category = 0;
	while ($cur_forum = $db->fetch_assoc($result))
	{
		if ($cur_forum['cid'] != $cur_category) // A new category since last iteration?
		{
			if ($cur_category)
			{
				echo "\t\t\t\t\t\t\t\t".'</div'."\n";
				echo "\t\t\t\t\t\t\t".'</fieldset>'."\n";
			}
			
			echo "\t\t\t\t\t\t\t".'<fieldset><legend><span>'.pun_htmlspecialchars($cur_forum['cat_name']).'</span></legend>'."\n";
			echo "\t\t\t\t\t\t\t\t".'<div class="rbox">';
			$cur_category = $cur_forum['cid'];
		}

		echo "\t\t\t\t\t\t\t\t".'<label><input type="checkbox" name="forums[]" id="forum-'.$cur_forum['fid'].'" value="'.$cur_forum['fid'].'" />'.pun_htmlspecialchars($cur_forum['forum_name']).'</label>'."\n";
	}

	echo "\t\t\t\t\t\t\t\t".'</div'."\n";
	echo "\t\t\t\t\t\t\t".'</fieldset>'."\n";
	echo "\t\t\t\t\t\t".'</div>'."\n";
	echo "\t\t\t\t\t\t".'</div>'."\n";
}

It should also be possible to remove some of the css from the stylesheets as well.

P.S. Any idea why the horizontal scroll for code boxes is not working here.

Comment edited 2 times (Diff, Diff 2)

Studio384 2012-09-11 14:24:48

This code works. The buttons are back small.

quy 2012-10-02 17:34:53

Commit 13a5e20 to fluxbb master

#719: Fixed markup for checkboxes in search.php. Patch provided by Paul.

quy 2012-10-02 17:36:22

  • Status changed from open to fixed.

Thank you Paul!