Ticket #652 (fixed bug)
Size(s) of avatars possibly negative
- Created: 2012-04-01 19:58:35
- Reported by: Wan
- Assigned to: Oldskool
- Milestone: 1.4.9
- Component: code
- Priority: normal
When setting avatar's size(s) (in administation/options), it's possible to set to negative size(s). A test about this is to be added...
Negative size(s) is not manageable... zero size useless... so a verification before submit would be necessary, don't you think ?
Oldskool 2012-04-02 20:48:26
- Owner set to Oldskool.
This is quite awkward indeed. Minimum should be 1 or avatars should be disabled altogether.
Oldskool 2012-04-02 20:56:09
Apparently negative values are possible on all integer fields, resulting in weird issues (like a negative amount on the "Redirect time" will make it appear forever/not actually redirect). Will update all the fields.
Franz 2012-04-02 21:01:39
- Milestone set to 1.4.9.
Franz 2012-04-03 10:04:02
Any more cases or can this be closed?
other cases are radio button I think
you can put -8000 in time format or date format ( on profile.php ) and it won't display a time or a date ( will display today everywhere ) ( but that does no wrong and only user tampering with it will see it ( and he can juste save with a good parameter ) )
There are more cases under:
Administration > Permissions
Administration > User groups
Administration > Maintenance
Oldskool 2012-04-07 14:22:29
Updated Permissions and User Groups pages as well. Pull request is inbound.
As for the Maintenance page, there are regex checks on there already that throw a "$field must be a positive integer" message on negative values, so that seems fine.
Franz 2012-04-08 15:47:10
Looks good, I think we're done here
Oldskool 2012-04-09 01:27:36
- Status changed from open to fixed.
Yeah, I reckon so. If any more similar fields are found, anyone please feel free to comment on this ticket with your findings and I'll reopen.