Fork me on GitHub
Subscribe 4

Ticket #574 (open enhancement)

Multiples tabs are not properly handled

  • Created: 2012-01-02 13:17:25
  • Reported by: adaur
  • Assigned to: None
  • Milestone: 2.0-alpha5
  • Component: parser
  • Priority: normal

I think multiple tabs should be trimed in order to keep a post clean.



Reines 2012-01-02 14:57:02

  • Milestone set to 1.4.8.
  • Visibility set to public.

There are a couple of questions with this issue.

  1. Just tabs, or all repetitive sequences?

  2. How many repetitions is too many?

  3. How do we handle it? During posting display an error? Or strip them out during parsing.

  4. What if people do "<space><tab>" repeated? This will have the same issue but can't be as easily detected. What about "abc" repeated? If we cannot detect and handle such situations is it worth handling single character repetitions?

Franz 2012-01-02 15:15:11

Isn't there a special character class for all kinds of whitespace when using regular expressions?

That should help us take care of 4.

Reines 2012-01-02 16:48:30

Well it fixes "<space><tab>", but not ".<tab>" or any other character that might be used in between.

Franz 2012-01-02 16:52:05

Ah yes, good point. Well, I suppose it's near impossible to take care of all things like that.

That's almost part of fighting spam, no?

Reines 2012-01-02 16:54:31

Well yes that was what I was getting at. We can easily block repetitive sequences of a single character, but is there really a point if it is that easy to get around?

Trying to block more than anything that simple is getting into some kind of intelligent anti-spam filters, which isn't something we want to get into - at least not in 1.4.x...

Franz 2012-01-03 13:58:26

  • Status changed from open to wontfix.

There are far too many combinations to this issue to allow for an easy fix (that wouldn't be too restrictive). Thus, we won't do anything about it now, sorry.

Ok, I'd say let's try to create some cool extensions in 2.0 then. smile

Reines 2012-01-03 13:58:37

  • Milestone changed from 1.4.8 to 2.0-alpha5.
  • Status changed from wontfix to open.

Franz 2012-01-03 14:00:53

Should this really be built into core?
I think it should be part of some (maybe official?) spam-recognition extension.

Reines 2012-01-03 14:03:01

No I don't think it should be in the core - but it might be sensible to ship an anti-spam extension enabled by default. I didn't intentionally re-open this - we both changed the ticket at the same time pretty much. Feel free to mark it as wontfix if you feel it's more appropriate.

Franz 2012-01-03 14:03:59

We'll see then.

daris 2012-01-03 14:25:20

Renies wrote:

we both changed the ticket at the same time pretty much.

It's next time, when it happens. What do you think about feature that will do not allow to post comment (or ticket change) when someone already posted comment in the same time?

Franz 2012-01-03 14:38:22

A good idea, but not really urgent for now, I'd say.