Fork me on GitHub
Subscribe 3

Ticket #507 (fixed bug)

htmlspecialchars in help.php for links

  • Created: 2011-10-12 05:59:09
  • Reported by: daris
  • Assigned to: quy
  • Milestone: 1.4.8
  • Component: markup
  • Priority: normal

<p><code>[ url]<?php echo pun_htmlspecialchars(get_base_url(true).'/') ?>[ /url]</code> <?php echo $lang_help['produces'] ?> <samp><a href="<?php echo pun_htmlspecialchars(get_base_url(true).'/') ?>"><?php echo pun_htmlspecialchars(get_base_url(true).'/') ?></a></samp></p>
        <p><code>[ url=/help.php]<?php echo $lang_help['This help page'] ?>[ /url]</code> <?php echo $lang_help['produces'] ?> <samp><a href="<?php echo get_base_url(true).'/help.php' ?>"><?php echo $lang_help['This help page'] ?></a></samp></p>

Shouldn't be htmlspecialchars used in above code also for help.php link like it is done for other links?
https://github.com/fluxbb/fluxbb/blob/f … lp.php#L58

History

Reines 2011-10-13 12:33:08

  • Milestone set to 1.4.8.

quy 2011-10-20 17:55:14

Commit d7ea47f to fluxbb fluxbb-1.4

#507: Apply a htmlspecialchars in help.php (noticed by daris)

quy 2011-10-20 17:57:10

  • Component set to markup.
  • Owner set to quy.
  • Status changed from open to fixed.