Fork me on GitHub
Subscribe 4

Ticket #494 (fixed bug)

Argument by reference in some functions

  • Created: 2011-09-18 14:51:50
  • Reported by: François
  • Assigned to: daris
  • Milestone: 1.4.8
  • Component: code
  • Priority: normal

Why does the $errors parameter is passed by reference in the functions split_text() and extract_blocks() ? (line 1754 and 1782 of the functions.php file)

Those functions don't touch to this variable, and it's caused errors with some hosts (maybe because of an PHP version)

History

Reines 2011-10-13 12:32:49

  • Milestone set to 1.4.8.

Mpok 2011-10-29 02:13:06

There is a 'Notice' in parser (line 883) which seems related with this bug (as it is the line which call "extract_blocks").
On Php4. (yep i'm STILL testing ur soft with this version… wink).

Mpok 2011-10-29 02:16:17

$errors is undefined in 'parse_message' function, which causes the 'Notice'…

Mpok 2011-10-29 02:21:38

But evermind, as François said, all these '$errors' should be removed everywhere, as they seem are just here to cause 'Notice' and tickets… smile

daris 2011-11-30 13:40:11

Commit 93b5ce2 to fluxbb fluxbb-1.4

#494 Remove unused $errors parameter from the split_text() and extract_blocks() functions

daris 2011-11-30 13:42:51

  • Owner set to daris.
  • Status changed from open to fixed.

Done smile

Mpok 2011-12-02 20:21:12

Thks.
Hope u also removed (if any) the param in calling these functions.

daris 2011-12-02 20:36:00

Commit 7130159 to fluxbb fluxbb-1.4

#494 Remove unused $errors parameter from strip_empty_bbcode() and preparse_list_tag() functions

daris 2011-12-02 20:38:07

Your comment made me look at code again and I found another unused $errors parameter (strip_empty_bbcode() and preparse_list_tag())

Mpok 2011-12-02 23:21:30

Nice job daris…