Fork me on GitHub
Subscribe 4

Ticket #476 (fixed bug)

Language files string "Forum mailer" not correct for some languages

  • Created: 2011-08-08 16:38:41
  • Reported by: Plazzmex
  • Assigned to: Franz
  • Milestone: 1.4.6
  • Component: localization
  • Priority: normal

There is a little "bug". It's not so bug so i'm not posting it in the bugs system, but here in the support.

The string 'Mailer' => 'Mailer', // As in "MyForums Mailer" in the signature of outgoing emails
is wrong for Hebrew language because in hebrew it must be in the form "Mailer MyForums" so when I translate the Mailer word here and then it attaches the forum name at the beginning it shown wrong in the mails

The solution might be just to make it like some other translation strings with an %s symbol so we could place it before or after the forum name.

History

Reines 2011-08-10 08:19:42

  • Milestone set to 1.4.6.

Franz 2011-08-11 21:29:17

I've got a patch prepared for this, but...

The problem with this is that this will seriously break every single email if the language pack is not updated.
This language-relevant word should have probably be put in the email template itself, anyway.

So what to do?

Franz 2011-08-11 22:12:13

  • Owner set to Franz.

Franz 2011-08-12 10:29:33

Commit 9bb1cf1 to fluxbb fluxbb-1.4

#476: Make "forum mailer" properly translateable.

Franz 2011-08-12 10:34:38

Ok, I have now included the word "Mailer" in the email templates.

The last problem remains with the notification emails. If the "%s" is not yet included in the language string (if there is an old language pack installed), emails will be sent from "Mailer"). Should we include a warning in the release announcement or what should we do?

FSX 2011-08-12 15:12:00

I think it's enough if we include a warning in the announcement.

Franz 2011-08-12 16:22:16

  • Status changed from open to fixed.

Wonderful. That's your job then wink