Fork me on GitHub
Subscribe 2

Ticket #458 (fixed enhancement)

Redirect to "edit ban" page when banning an already banned user

  • Created: 2011-06-21 21:28:24
  • Reported by: Koos
  • Assigned to: Franz
  • Milestone: 1.4.6
  • Component: bans
  • Priority: normal

Let's say you ban a user until 2011-07-01, and immediately thereafter ban the same user again, but this time until 2011-07-10. The user will then receive a message when trying to log in notifying him of the first ban and that it will expire 2011-07-01. The user will then try to log in after 2011-07-01, but then receive another message that he is banned until 2011-07-10.

My suggestion is to redirect to the "edit ban" page when trying to ban an already banned user. See patch.

History

Koos 2011-06-21 21:29:27

  • Uploaded patch Report.patch. (view)

Franz 2011-06-22 13:38:28

  • Component set to bans.
  • Milestone set to 1.4.6.

That looks like a very, very good idea. Thank you for the patch!

Franz 2011-06-22 13:43:14

P.S.: Did you know that you can use Git to generate patches from changes in your working copy? That would also give you full credit by giving you author status wink

Another tutorial: http://ariejan.net/2009/10/26/how-to-cr … -with-git/

Franz 2011-06-29 20:16:33

  • Owner set to Franz.

Franz 2011-07-01 12:24:34

Commit 7e893e3 to fluxbb fluxbb-1.4

Ticket #458: Redirect to edit ban page when banning an already banned user.

Idea and patch by Koos. Thanks.

Franz 2011-07-01 12:29:01

  • Status changed from open to fixed.

Thank you very much, I applied this.

Franz 2011-07-01 12:29:34

I actually also added an URL parameter to allow for adding a message on the "edit ban" page, because this might actually be unexpected. Does that sound like a sensible idea?

The other option would be to simply change the link to read "Edit ban".