Fork me on GitHub
Subscribe 5

Ticket #430 (fixed enhancement)

Use same anchor text in search breadcrumbs to link back to the search page.

  • Created: 2011-05-05 20:58:16
  • Reported by: Koos
  • Assigned to: Reines
  • Milestone: 1.4.6
  • Component: usability
  • Priority: normal

i.e. when you search for topics and posts, the breadcrumbs are displayed as:

Index » Search topics » With posts with keywords 'fluxbb'

when searching topics, and

Index » Search posts » With keywords 'fluxbb'

when searching posts.

The anchor text should be the same since they both link to the same page (search.php).

Currently:

a9pqc8.png

Recommended:

2ez5k49.png

I'm attaching a patch that shows my recommendation for how the breadcrumbs should look like.

History

Koos 2011-05-05 20:59:23

  • Uploaded patch Report2.patch. (view)

Koos 2011-05-05 21:07:21

My patch includes a fix for line 545 of search.php where

pun_htmlspecialchars($keywords)

should be

urlencode($keywords)

Koos 2011-05-13 15:03:52

Any thoughts on this?

Reines 2011-05-15 17:47:17

  • Component set to usability.
  • Milestone set to 1.4.6.
  • Type changed from task to enhancement.

Franz 2011-05-18 16:08:48

What is wrong about how it's done? I think the breadcrumbs currently are more informative, as you can clearly see which query led to the current page.

Apart from that, the two pages with the different crumbs you mentioned are clearly different, too (and have different links - take a look at the URL parameters). One shows a list of topics, the other one lists a bunch of posts.

Franz 2011-05-18 16:09:42

I just took a look at your patch and noticed that you're basically suggesting to revert ticket #58. Why?

Koos 2011-05-24 21:52:13

You can't have different link texts for linking to the same page.
i.e.
"Search topics" linking to search.php
and
"Search posts" also linking to search.php

Anyway, the user who did the search can already see in the layout of the search results what he searched for (topics/posts). I also think it's clumsy to have a link in the search crumbs called "With posts with keywords...”

taylorchu 2011-05-25 02:19:46

@Koos
I agree. Current implementation is confusing.
I used your patch.

Franz 2011-05-25 11:40:54

Bring it to the community in a topic.

quy 2011-06-01 22:57:27

To accommodate both implementations, keep the code as it and to display them per your suggestion, change the search strings as follows:

'Search topics'                        =>    'Search',
'Search posts'                        =>    'Search',
'Quick search show_user_topics'        =>    'Search results',
'Quick search show_user_posts'        =>    'Search results',
'Quick search show_subscriptions'    =>    'Subscriptions',
'By keywords show as topics'        =>    'Search results',
'By keywords show as posts'            =>    'Search results',
'By user show as topics'            =>    'Search results',
'By user show as posts'                =>    'Search results',
'By both show as topics'            =>    'Search results',
'By both show as posts'                =>    'Search results',

quy 2011-06-03 00:38:04

pun_htmlspecialchars($keywords)

should be

urlencode($keywords)

Fixed.

taylorchu 2011-06-06 01:10:28

I think this is a translation issue. The search anchor text is not helpful if it is not well-written.

Reines 2011-06-07 14:29:30

Commit b9f1e01 to fluxbb fluxbb-1.4

Altering the search strings, as an attempt at solving #430. This is
just a test and may get reverted still.

Reines 2011-06-07 14:36:33

  • Owner set to Reines.
  • Status changed from open to fixed.

I think the above commit works quite well - I've applied to to fluxbb.org for anyone who wants to give it a check. It renames the second breadcrumb to just "search", since it links to search.php with no arguments. The final breadcrumb has the entire description, and links to the appropriate arguments.

Koos 2011-06-16 21:57:56

Looks good.