Fork me on GitHub
Subscribe 1

Ticket #41 (fixed enhancement)

LIMIT X,Y is used in various places other than just displaying posts

  • Created: 2010-06-06 14:21:49
  • Reported by: Reines
  • Assigned to: Reines
  • Milestone: 1.4.2
  • Component: database
  • Priority: normal

We replaced the query for displaying posts with 2 queries as it improves performance. LIMIT X,Y appears in a few other places, we should do some testing to see if replacing them would also provide a performance benefit.

History

Reines 2010-07-21 23:06:43

  • Milestone changed from 1.4.1 to 1.4.2.

Reines 2010-07-24 13:31:49

I have now applied this to viewforum.php.

Other places that it should be considered: moderate.php...

Reines 2010-07-24 13:33:08

Commit a72e6e8 to fluxbb fluxbb-1.4

Splitting the topic list query into 2 parts to work around poor performance of LIMIT. See #41. Also fixed a bug here whereby multiple posts being posted at the same time (i.e. with the same timestamp) would be sorted incorrectly.

Reines 2010-07-24 14:00:24

Now applied to moderate.php too.

Still to check:

  • userlist.php

  • search.php

Reines 2010-07-24 14:44:10

  • Status changed from open to fixed.

Reines 2010-07-31 16:49:39

  • Status changed from fixed to open.

Reopening: This also should be performed in extern.php

Reines 2010-07-31 17:10:00

  • Status changed from open to fixed.

Nevermind, extern seems to only use LIMIT y rather than LIMIT x,y - which I don't think is a problem.