Fork me on GitHub
Subscribe 3

Ticket #380 (fixed bug)

Javascript error on db_update

  • Created: 2011-03-26 09:24:30
  • Reported by: ridgerunner
  • Assigned to: quy
  • Milestone: 1.4.6
  • Component: javascript
  • Priority: normal

History

Reines 2011-03-26 09:25:22

  • Status changed from open to fixed.

ridgerunner 2011-03-27 17:37:14

Removed dependency on Javascript for db_update. Fixes "whitescreen" failure on Opera 11 when Javascript is disabled.
Git commit #57f123102264321a9758cc4718298505f7274142

Reines 2011-03-27 17:41:38

I don't think that'll work if upgrading from 1.2, since we output information while doing the upgrade, and you can only set headers if nothing has been output yet.

ridgerunner 2011-03-27 19:02:21

Yes, header() only works if there is no output already. Sorry for the premature commit change. However, the previous way (with the HTML markup) is no good either (unless you want to abandon support for Opera). I'm not sure what the best solution is - but I strongly suggest that it work seamlessly with JS turned off. Since you are intimately familiar with this (complex) script, I'll let you figure it out.

Reines 2011-03-27 20:37:02

  • Status changed from fixed to open.

Reines 2011-03-27 20:43:40

No problem, I'll take a look at it.

Though do you know why it is failing on Opera if the javascript error has been fixed?

Reines 2011-03-27 20:58:13

Actually another point:

Smartys wrote:

You shouldn't be changing the JavaScript redirects to header redirects. Browsers have built-in limits to the number of 30x redirects that they follow. For Firefox 3.6, that number is 20 by default (see network.http.redirection-limit in about:config). After 20, your request will simply return an error.

so really it looks like javascript is the only real option here...

Reines 2011-04-16 20:53:17

  • Owner changed from ridgerunner to Reines.

quy 2011-04-20 19:38:07

  • Owner changed from Reines to quy.
  • Status changed from open to fixed.

Fixed using meta refresh when Javascript is disabled.