Fork me on GitHub
Subscribe 4

Ticket #338 (fixed bug)

Quoting users with special character usernames fails

  • Created: 2011-03-08 10:45:51
  • Reported by: Oldskool
  • Assigned to: Reines
  • Milestone: 1.4.5
  • Component: parser
  • Priority: normal

Whenever a user with a quote in their username is being quoted, like this:

[quote='[Camp]']I still hate them lol[/quote]

It seems not te escape the username properly and returns this:

[Camp] wrote:

I still hate them lol

As reported by x3dt here: https://fluxbb.org/forums/viewtopic.php?id=5237

History

Oldskool 2011-03-08 11:00:28

Hmm, looking at it again it actually seems to break on the closing bracket (]) instead of the quote. So it seems to ignore the fact that no closing quote is used and matches the bracket as end of the quote tag.

Oldskool 2011-03-08 11:01:28

  • Summary changed from Quoting users with quotes in their username fails to Quoting users with special character usernames fails.

Reines 2011-03-08 11:28:59

It works fine when using " instead of '.

[Camp] wrote:

I still hate them lol

Is ' meant to actually work, or is " the correct way to do it? Or should we make it work for both?

Oldskool 2011-03-08 12:31:41

I guess it should be OK to make double quotes the default behaviour whenever clicking the quote link.

Reines 2011-03-11 09:28:43

  • Component set to parser.

Reines 2011-03-13 19:02:57

  • Owner set to Reines.
  • Status changed from open to fixed.