Fork me on GitHub
Subscribe 5

Ticket #332 (fixed bug)

BBCode in URLs is parsed

  • Created: 2011-03-02 23:30:18
  • Reported by: Oldskool
  • Assigned to: Franz
  • Milestone: 1.4.6
  • Component: parser
  • Priority: normal

Whenever BBCode is put inside of an URL, it is parsed and translated to raw HTML. For example:

[url][_b]MySite.com[_/b][/url]

Results in this (without the underscores):

<strong>MySite.com</strong>

It can also be seen here: https://fluxbb.org/forums/viewtopic.php … 999#p38999

As originally found and reported by Franz, just thought this should be a ticket instead of a report.

BBCode inside URL tags should be discarded as it's an invalid place, should always be outside the url tags.

History

Oldskool 2011-03-02 23:30:43

  • Description changed. (Diff)

Oldskool 2011-03-02 23:34:28

  • Description changed. (Diff)

Reines 2011-03-03 13:45:54

The easy solution to this would just be to not allow tags inside url tags?

quy 2011-03-03 16:31:44

But then you won't be able to use the image tag inside the URL tag or will the image tag be excluded?

Reines 2011-03-03 16:34:17

Hmm yeah true. I guess it's slightly awkward because  with url=... tags it makes sense to allow tags inside it, however with plain url tags it doesn't.

Oldskool 2011-03-03 20:01:15

Agreed, this is specifically regarding plain url tags. Inside that, there should only be an URL and not an image tag. It would not make any sense, since you are not specifying where the image should link to anyway. So all BBcode inside  should just be discarded IMO.

taylorchu 2011-03-13 18:08:45

//parser.php

    $tags_limit_bbcode = array(
        '*'     => array('b', 'i', 'u', 's', 'ins', 'del', 'em', 'color', 'colour', 'url', 'email', 'list', 'img'),
        'list'     => array('*'),
        'url'     => array('img'),//url should only have image
        'email' => array(),//nothing should be in email
        'img'     => array(),//nothing should be in image
        'h'    => array('b', 'i', 'u', 's', 'ins', 'del', 'em', 'color', 'colour', 'url', 'email'),
    );

Reines 2011-03-20 12:28:33

  • Milestone changed from 1.4.5 to 1.4.6.

Franz 2011-07-23 22:27:47

Is everybody ok with only images being allowed inside url tags? And if so, this should apply for forum, topic and user tags, too, right?

Franz 2011-07-23 22:43:53

  • Owner set to Franz.

Ah well, this is how I will do it now. Some decisions just have to be made wink

I would argue that there isn't much need for formatting inside url tags anyway - reasons would mostly be dubious, I suppose.

Franz 2011-07-23 22:44:40

Commit db66ecd to fluxbb fluxbb-1.4

#332: Only allow img tags inside all types of link tags.

Franz 2011-07-23 22:45:12

  • Status changed from open to fixed.