Fork me on GitHub
Subscribe 4

Ticket #273 (fixed task)

Tabindex needs checked

  • Created: 2011-02-03 08:38:35
  • Reported by: Reines
  • Assigned to: Franz
  • Milestone: 1.4.6
  • Component: markup
  • Priority: low

In various places the tabindex count has got messed up. We should always track it using some var:

... tabindex="<?php echo $tab_index++; ?>" ...

It is currently incorrect in login.php, and no doubt other places too.

History

Franz 2011-02-03 16:15:52

  • Owner set to Franz.

Franz 2011-02-08 21:37:35

Ugh. How should code like this be handled?

<th scope="row"><?php echo $lang_admin_bans['Username label'] ?><div><input type="submit" name="add_ban" value="<?php echo $lang_admin_common['Add'] ?>" tabindex="2" /></div></th>
<td>
    <input type="text" name="new_ban_user" size="25" maxlength="25" tabindex="1" />
    <span><?php echo $lang_admin_bans['Username advanced help'] ?></span>
</td>

quy 2011-02-08 22:23:54

I posted this question previously and Paul replied (link).

This is not the answer to your question, but something to consider.

quy 2011-02-08 22:54:43

How about moving the location of the button after the text field?

quy 2011-02-09 00:00:28

Here is an article recommending against using tabindex.

taylorchu 2011-02-09 03:49:54

personally, tabindex should be removed. now it might be a good chance to do so.

Franz 2011-02-09 08:22:28

How about removing it for everything but the login page, where (I think) we are using it to jump to the login button before jumping to links like "Forgot password?" etc.

quy 2011-02-09 15:06:28

From an usability article:

Remove extra elements between form controls to keep information together. For instance, you shouldn't include a "lost password" link or something else between the password input box and its descriptive text. Place those options outside the form instead.

This saves a few keystrokes between related elements. It can also help keep a screen reader from associating the phrase "Lost Your Password?" with the password input box instead of your intended "Enter Your Password Here" descriptive text.

PunBB login is done this way. I also have noticed this setup on many major sites.

Franz 2011-03-11 12:21:23

  • Milestone changed from 1.4.5 to 1.4.6.

This is difficult and I'm busy with other tickets and more stuff currently. Going to delay this.

Reines 2011-03-12 15:52:54

  • Priority changed from normal to low.

Reines 2011-06-08 15:29:17

For this ticket we should simply fix any areas where it has gone wrong. In 2.0 we can solve this properly, probably by removing the tabindex all together.

Franz 2011-06-11 22:37:09

I am almost done with all pages. admin_forums.php is weird, the permission checkboxes are hard to accessing using tabs. For me, Chrome lets me tab through the top six elements as specified. After the "Save changes" button (position six - we will not be able to simulate this with markup order, so maybe tabindex is useful after all?), I need to tab through all links (menu and submenu) until I get down there. How should this be handled?

Franz 2011-06-11 22:40:35

Commit 3245cfa to fluxbb fluxbb-1.4

#273: Fix tabindex values in login.php.

quy 2011-06-16 01:52:39

  • Uploaded patch tabindex.patch. (view)

See if the attached patch will do the trick.

Franz 2011-07-06 12:21:05

Commit aab45ab to fluxbb fluxbb-1.4

#273: Fix tabindex in admin_forums.php

Franz 2011-07-06 12:28:44

Commit cdd7499 to fluxbb fluxbb-1.4

#273: Add tabindex to edit and delete links in admin_forums.php.

Franz 2011-07-06 12:46:33

Commit 3fb9db7 to fluxbb fluxbb-1.4

#273: Fix tabindex in admin_groups.php. Ugh.

Franz 2011-07-06 12:47:44

  • Status changed from open to fixed.

What a mess. Well, I'm done now.