Fork me on GitHub
Subscribe 3

Ticket #27 (fixed enhancement)

Reorganize quick searches

  • Created: 2010-05-27 22:43:20
  • Reported by: Franz
  • Assigned to: Franz
  • Milestone: 1.4.3
  • Component: search
  • Priority: normal

It might be nice to have some more different user post searches, just like v1.3 had them.

As part of this, we can also allow admins (and moderators) to view the topics other users are subscribed to.


Reines 2010-05-27 23:15:25

  • Type changed from task to enhancement.

Franz 2010-06-13 22:08:53

  • Owner set to Franz.

Reines 2010-06-25 19:04:21

  • Milestone 1.4.1 removed.

Reines 2010-06-30 21:54:57

  • Milestone set to 2.0-beta1.

Reines 2010-08-12 18:18:22

  • Milestone changed from 2.0-beta1 to 1.4.3.

Franz 2010-10-13 12:40:14

As part of this, should we allow quick searches to happen on a per-user basis, too? Currently, one can only view subscriptions belonging to themselves. In 1.3, administrators were also able to see all topics a certain user was subscribed to.

Franz 2010-10-17 21:31:36

Commit f086803 to fluxbb fluxbb-1.4

Implement more user post searches (ticket #27).
New are:
* show_recent, which replaces show_24h, because it also provides another parameter to show posts from another time interval.
* show_user_topics, which shows all topics created by a user.
* show_user_posts, which replaces the old show_user, but instead of simply listing the topics the user has posted in shows all of these posts.
Backwards compatibility is taken care of, the old links should still work.

Franz 2010-10-21 21:33:10

  • Description changed. (Diff)
  • Summary changed from More user post searches to Reorganize quick searches.

Franz 2010-10-27 13:55:50

I created two more tickets for the related tasks:
#169 and #170.

Franz 2010-10-27 14:40:57

Note to self: I think I broke the "active topics" quick search. It doesn't show any results to me. Also, the error message if no topics are found, may be incorrect if another interval than 24 hours is specified.
Is that important, though?

Franz 2010-10-27 22:18:04

Implementation finished - pull request created.

Franz 2010-11-23 00:41:58

We have yet to find a place to move the "Mark as read" links to. Paul is checking that.

Something also went wrong with merging profile.php. I'll try to reapply those changes tomorrow.

quy 2010-11-23 04:20:44

When displaying quick searches, check that the user group has "Read board" permission.

Franz 2010-11-24 09:55:05

Thanks, done that now.

Could you make sure that the new links in profile (view all user posts, topics and subscriptions) are only displayed when the user has the right permissions, please? I have checked, too, but I'd feel safer with a review.

quy 2010-11-24 16:01:49

In the latest commit, no need to check "Read board" permission on line 213 since the user is already logged in.

When "User post count" is set to No, "Show all subscriptions" link is not available to non admins.

I will continue to review for other scenarios.

Franz 2010-11-24 17:10:18

Consider a group being created just for new members. With no permissions, until they get reviewed and moved to another group. A pretty common scenario.

quy 2010-11-24 17:32:44

Good point. In that case, "Mark all topics as read" should also be hidden.

quy 2010-12-01 15:54:03

With this commit, "Mark forum as read" does not display when Subscriptions is disabled.

Franz 2010-12-02 10:48:39

And fixed that, too. Good catch, thanks.

I will let Paul take care of the "mark all forums as read" link. That will be the very last thing to finish this ticket.

quy 2010-12-05 04:00:14

When "User post count" is set to No, "Show all subscriptions" link is not available to non admins.


Reines 2011-01-22 16:29:38

What needs done with the "mark forum as read" links? Is it the one on the index, or viewforum?

quy 2011-01-22 19:04:27

With new styles, these options are on one line that wrap for board width less than 960px:

There are new reports * Mark all topics as read * New posts * Active topics * Unanswered topics

You can see it on this board when a report is submitted.

Paul proposed to redesign placements.

The discussion is here:

This ticket is basically done except for Paul's markup. Lets close this ticket in order to not delay 1.4.3 further. Open a new ticket for Paul's markup for 1.4.4.

Reines 2011-01-22 20:51:12

  • Status changed from open to fixed.

Makes sense, I've created a new ticket for 1.4.4.