Fork me on GitHub
Subscribe 2

Ticket #266 (fixed bug)

Subscription emails are not censored

  • Created: 2011-01-30 19:49:58
  • Reported by: Reines
  • Assigned to: Franz
  • Milestone: 1.4.5
  • Component: code
  • Priority: normal

When censoring is enabled, messages included in subscription emails are not censored.

History

Franz 2011-02-03 16:16:23

  • Owner set to Franz.

Reines 2011-02-03 16:24:26

This should probably be done at the same time as #257. We can keep a copy of the original message, a pre-parsed copy, and a pre-parsed+censored copy to run checks against as well as include in subscription emails.

Franz 2011-02-03 16:29:53

True, good point.
I will do that other one, too.

Franz 2011-02-09 10:06:30

Commit 7562628 to fluxbb master

#257 and #266: Apply censoring before validating new posts and topics. Also censor messages in subscription mails.

Franz 2011-02-09 10:09:06

  • Status changed from open to fixed.

Fixed that in 7562627.

Some quick testing would be appreciated. (I did test, too, but maybe I forgot something.)

Reines 2011-02-09 10:14:30

On a similar topic, though not subscription related, should we censor emails sent using the email from (i.e. around line 100 in misc.php)?

Franz 2011-02-09 12:58:31

I would argue no.
I suggest you post a topic in the forums if you want more community input, though.

Reines 2011-02-09 22:14:37

Franz wrote:

I would argue no.

Why? Surely censoring should apply to the whole board?

Franz 2011-02-09 22:27:31

Sending private emails is something different in my eyes.

Just imagine me sending you an email explaining that you're banned because of using that and that and that swear word.
(Ok, this might seem far fetched. Anyway, an email with content different than what I wrote would be sent - and I wouldn't see it).