Fork me on GitHub
Subscribe 4

Ticket #248 (fixed enhancement)

Move the mark as read link

  • Created: 2011-01-22 20:50:52
  • Reported by: Reines
  • Assigned to: Reines
  • Milestone: 1.4.4
  • Component: markup
  • Priority: normal

With new styles, these options are on one line that wrap for board width less than 960px:

There are new reports * Mark all topics as read * New posts * Active topics * Unanswered topics

You can see it on this board when a report is submitted.
Paul proposed to redesign placements.
The discussion is here: http://fluxbb.org/forums/viewtopic.php?id=4788

History

Reines 2011-01-26 11:20:51

  • Milestone changed from 1.4.4 to 1.4.5.

wonder 2011-01-27 16:48:56

i'm not sure if i should open a new bug about this but Mark all topics as read is missing after clicking New posts. To mark all of them as read i have to go back or click on index.

Franz 2011-01-27 17:07:48

It's not a bug. As this link only makes sense on the index page, we only display it there.

That's one of the good things of moving it: It going "missing" will not be as apparent wink

Hope that makes sense.

wonder 2011-01-27 17:14:48

imo that "feature" is the most used ever or maybe i just use the forum in the wrong way...

Reines 2011-01-27 19:25:05

I'm not sure I necessarily agree about it not making sense on the new posts page. Fair enough for all the other quick searches, but on the new posts page only new posts show up - so marking all as read does have the result you'd expect.

toofishes 2011-01-28 22:14:15

  • Uploaded patch 0001-Show-mark-read-link-on-New-Posts-page.patch. (view)

The only place I ever used the damn link was the new posts page- it *needs* to be on that page, going back to the index is absolutely ridiculous to have to find the link.

To prove my point, on a site with traffic, why don't we look at where the referrers for the markread action come from pre-1.4.3 upgrade.

zcat bbs-access_log.2.gz | grep "markread" | grep -o '"https:[^"]*"' | sort | uniq -c | sort -n

     88 "https://bbs.archlinux.org/index.php"
    172 "https://bbs.archlinux.org/"
   1821 "https://bbs.archlinux.org/misc.php?action=markread"
   2436 "https://bbs.archlinux.org/search.php?action=show_new"

Untested patch attached to fix this pointless regression and *most commonly used* navigation path.

toofishes 2011-01-28 22:36:55

Running with the above patch on bbs.archlinux.org now and things seem to be working fine- the link still shows for the index, shows for new posts, but does not show for any other search page.

Reines 2011-01-28 22:56:09

I've commit your patch, cheers.

toofishes 2011-01-28 23:51:13

Thanks! Appreciate the quick response.

wonder 2011-01-29 10:39:41

the patch doesn't take in consideration pagination. It is available only on the first page and once you click on the second, the Mark as read link is gone

Reines 2011-01-29 10:51:27

  • Milestone changed from 1.4.5 to 1.4.4.

Reines 2011-01-29 12:13:12

Ah thank you wonder, I'll see if I can sort that.

The easiest solution is simply to add it back to all search related pages, but I'm not so keen on that. The mark as read link works by updating your last visit time to now - all posts before your last visit time are assumed to be read.

On the index or new posts pages this makes sense, but on a regular search, or the unanswered topics (for example) this isn't the expected behaviour - you would expect it to mark all currently visible posts as read, which is not what it would do. This is the main reason it was removed - we simply forgot that it makes sense (and is important) on the new posts page.

On a note more related to this actual ticket, you may have noticed we have a "mark this forum as read" link at the bottom of the page on viewforum.php. I think putting both of these in the same place makes sense, so that's just a case of deciding if the bottom or top is better.

Franz 2011-01-29 17:58:00

Bottom. tongue
We also don't have enough space up there. Plus, somebody made a very good point at the ArchLinux forum.

Reines 2011-01-30 14:54:23

  • Owner set to Reines.

Right - I've fixed the paging issue, and moved the link to the bottom right. I've just to move the link on the index to the bottom right then I'll commit the changes.

Reines 2011-01-30 15:03:53

I've commit this. I've still to handle the link on the index - I'll do this soon then commit and hopefully close this ticket.

Reines 2011-01-30 16:03:38

  • Status changed from open to fixed.

I've now moved this to the bottom right on the index page.

PS. I suck at markup/CSS so hopefully this is okay...