Fork me on GitHub
Subscribe 1

Ticket #24 (fixed enhancement)

Consistency in coding style

  • Created: 2010-05-26 08:05:43
  • Reported by: Reines
  • Assigned to: Reines
  • Milestone: 1.4.0
  • Component: code
  • Priority: lowest

There are a few places which still use rather out-dated styles of coding, for example

while($bla = @each($array))

instead of

foreach ($array as $bla)

and

$d = dir('style');
while (($entry = $d->read()) !== false)
{
[...]
}
$d->close();

rather than

$entries = glob('style/*');

Having these all using consistent and more up-to-date methods would be nice, though far from critical.

History

Reines 2010-05-26 08:06:06

  • Priority changed from low to lowest.

Reines 2010-06-13 16:05:39

  • Status changed from open to fixed.

Done in f74225d, da01a73, 554feff, and 2656a29. I decided against using glob() as it seems it is often blocked by (stupid) hosts using safe mode.

Franz 2010-06-13 16:18:09

  • Milestone changed from 1.4.1 to 1.4.0.