Fork me on GitHub
Subscribe 2

Ticket #173 (fixed enhancement)

Only regenerate quickjump cache when necessary

  • Created: 2010-10-29 22:44:29
  • Reported by: Franz
  • Assigned to: Franz
  • Milestone: 1.4.3
  • Component: caching
  • Priority: normal

There are some cases when only one specific group is being edited. In those cases, it is not necessary to regenerate the quickjump cache for every single user group. It can simply only be done for that particular group.

History

Franz 2010-10-29 22:46:00

Okay, there was only one case. But we also regenerated the cache for a group that was being deleted...

quy 2010-10-30 15:08:06

Jump menus are no longer displayed and here is its content.

<?php

if (!defined('PUN')) exit;
define('PUN_QJ_LOADED', 1);

?>

Franz 2010-10-30 15:24:43

When and where? For whom? Can you come on IRC to discuss this? I can't replicate the behaviour...

quy 2010-10-30 16:02:33

In generate_quickjump_cache function, I removed this parameter ", true", and it is working again.

Franz 2010-11-15 20:38:56

Do you still have this problem, quy?
This is now in master.

quy 2010-11-15 21:21:54

It is working on a live server, but not on my test server using XAMPP. Go ahead and close it for now. Thanks.

Franz 2010-11-23 00:36:09

  • Status changed from open to fixed.

Ok, closing this now.

Reading through your comments again, I'm not sure what you mean. I cannot find a call to generate_quickjump_cache() with the parameter being set to true. And that wouldn't make sense anyway, since that parameter is omitted (or false) or a group ID.

Franz 2010-11-24 00:02:12

  • Status changed from fixed to open.

I think it is working on the live server because the patch didn't get applied correctly during merging. The changes are now pushed to the master branch again.

Could you check whether this error still exists and, if so, try to debug?
It probably has to do with the additional permission check I added.

quy 2010-11-24 00:41:08

This is working locally and on the live server. Thanks!

Franz 2010-11-24 09:38:29

  • Status changed from open to fixed.

Great!