Fork me on GitHub
Subscribe 4

Ticket #169 (fixed enhancement)

Show quick jump dropdown list on all pages

  • Created: 2010-10-27 13:53:09
  • Reported by: Franz
  • Assigned to: Franz
  • Milestone: 1.4.3
  • Component: usability
  • Priority: normal

There is much more use to the quick jump dropdown list in the footer if it is displayed on all pages (maybe except for the index).

This will be done as part of the footer bar restructuring that is currently going on because of ticket #27.


Franz 2010-10-29 14:28:59

We have a small problem. It is small, but should be mentioned anyway.

With the current quick jump code, the quick jump selector looks pretty bad (because empty) when the user can not view any forums.
It also looks weird when e.g. guests are not allowed to read any forums, but are not explicitly prohibited to read every single one of these forums. Thus, the quick jump bar still shows the forum list, but at the same time you cannot view any of them on the index page (or when selecting them).

Is it worth it to look into the first issue? I'm sure I should fix the second problem.

taylorchu 2010-10-29 17:43:27

the solution is simple though. Only display quick jump when the list is not empty.

could be done in one if statement

Franz 2010-10-29 18:25:33

That doesn't fix the second problem, though. Because the list will not be empty.

I'll look into it...

Franz 2010-10-29 22:16:32

I fixed the issue.

It is theoretically possible that user groups are simply prohibited to view the forum for every single forum there is. Should I take care of that case, too?

Franz 2010-10-29 22:36:52

I did take care now.

quy 2010-11-04 05:17:37

$forum_id is undefined on all pages except for viewforum.php and viewtopic.php.

Franz 2010-11-04 20:35:08

Fixed, thank you.

quy 2010-11-04 22:46:13

Would it be better to test for $forum_id once (as follows) than for each option?

define('PUN_QJ_LOADED', 1);
$forum_id = isset($forum_id) ? $forum_id : 0;

Franz 2010-11-04 23:49:28

Thank you, excellent point again.
I've now added this to the integration branch.

I had accidentally committed my first "fix" in our master branch, which means we can just choose "theirs" when merging the integration branch.

Franz 2010-11-15 20:36:45

  • Status changed from open to fixed.

Pushed by Frank.

quy 2010-11-15 21:27:09

Don't forget to implement this instead:

define('PUN_QJ_LOADED', 1);
$forum_id = isset($forum_id) ? $forum_id : 0;

Franz 2010-11-23 00:27:13

Ok, added this now. Thanks once more!

quy 2010-11-23 04:05:26

This commit is not in the latest version.

Franz 2010-11-23 23:58:39

Okay, I now pushed the changes that somehow got left out during the pull request merge.