Fork me on GitHub
Subscribe 1

Ticket #149 (fixed enhancement)

Support for HTTPS

  • Created: 2010-09-30 16:03:45
  • Reported by: Reines
  • Assigned to: Reines
  • Milestone: 1.4.3
  • Component: code
  • Priority: normal

It would be nice to add proper support for HTTPS. At the moment the base_url will either be set for HTTP or HTTPS, and only work (i.e. pass referer checks, and link to the correct URL for smilies etc.) with one. It would be handy to make it support both, and shouldn't be too much work.


Reines 2010-10-20 20:52:22

  • Owner set to Reines.

Reines 2010-10-22 11:54:33

I've updated the confirm_referrer() function to ignore the URL scheme and port.

There are still 2 referer checks in login.php and misc.php which need sorted, smilies in help.php and include/parser.php, avatars and redirect function in functions.php.

Reines 2010-10-22 21:07:34

I've now updated the parts in login.php and misc.php.

Left to do:

  • help.php

  • include/parser.php

  • functions.php

Reines 2010-10-23 11:37:30

Question: Why do we use absolute paths for smilies and avatars, but relative URLs everywhere else?

Reines 2010-10-23 11:53:44

  • Status changed from open to fixed.

I've now added support for the final areas. There are still a few areas where $pun_config['o_base_url'] is used without the wrapper, but that is fine as they are in subscription emails, and it makes sense to use whatever the default protocol is for emails rather than whatever the person making the post happens to use.

I've also imported these changes into and removed our old hack to allow HTTPS support, so if anyone notices any problems please shout.