Ticket #142 (fixed enhancement)
- Created: 2010-09-21 14:13:51
- Reported by: jojaba
- Assigned to: Franz
- Milestone: 1.4.3
- Component: syndication
- Priority: normal
When a user subscribe to a forum, it would be a good thing that a notification is sent if a new Topic or a new post is posted to that forum...
Reines 2010-09-22 15:44:41
- Component changed from tools to syndication.
- Milestone set to 1.4.3.
- Owner set to Reines.
I am quite a fan of this idea, so I'm going to mark it for 1.4.3 at the moment. If anyone has any arguments against, then please speak up!
Reines 2010-09-30 18:05:21
I've implemented this now, though currently the db_update stuff doesn't work on SQLite2.
This could probably do with a little testing...
Franz 2010-09-30 18:50:56
- Summary changed from New topic notification request to Forum subscriptions.
There are several instances of the following to be changed:
Reines 2010-09-30 21:04:16
Cheers, sorted those. I haven't tested the db_update script properly yet, and it still doesn't work for SQLite. Will check/sort it out later.
Here are 2 trivial changes in misc.php for your consideration:
- change ' ,' to ', '
- instead of 2 if statements, change it to be "if else if" statement since it is either topic or forum that is being performed to.
Reines 2010-10-01 17:11:15
- Status changed from open to fixed.
Franz 2010-10-22 23:00:25
Should there be a page with subscribed forums somewhere? I realize this would have to be created somewhat (if not entirely) from scratch.
Reines 2010-10-22 23:07:17
Potentially, but since there are generally not many forums I wouldn't say it's as vital as the list of subscribed topics.
Christian 2010-10-29 23:16:47
I think it would be a good idea to trigger the notification email only for the first new topic created in a subscribed forum.
Christian 2010-11-09 19:57:19
- Status changed from fixed to open.
Please consider my last comment
Reines 2010-11-09 20:10:10
I'm not sure that really makes sense when talking about new topics - each new topic is individual, whereas in a post the replies are all linked to each other.
For example, suppose you subscribe to the announcements board here - presumably you would want to know of each announcement, not just the next one that is posted.
Christian 2010-11-09 21:23:23
When talking about the announcements forum, I agree with you.
But for all the other forums, I only want to be notified when something happened there (new topic OR new post) and doesn't want to receive an e-mail for every new topic that gets posted.
While this is my subjective opinion, we should at least remember FluxBB being lightweight thus not sending thousands of mails everytime a post is made to a forum.
We could possibly solve this issue by allowing admins to configure if a notification should be sent for every new post or only once on a per-forum basis.
Franz 2010-11-09 23:20:35
The extra option sounds like an alternative, but then it might add too much complexity. How about thinking about this for 1.4.4?
Christian 2010-11-09 23:38:33
I'm fine with pushing this to 1.4.4, but then forum subscriptions should either be removed in 1.4.3, changed to not send e-mails for every new topic or there needs to be an own admin option for switching this off (not bound to the post subscriptions).
Franz 2010-12-06 21:58:14
- Owner changed from Reines to Franz.
Ok, I'll add an option for switching forum subscriptions on/off tomorrow.
We can look into more fine-grained controls for this feature in 1.4.4, if you add another ticket
Franz 2010-12-07 23:38:34
- Status changed from open to fixed.
I've implemented an option for switching forum subscriptions on / off separately. I hope this suits everybody.
On a sidenote: the default value should still be on, right?
Franz 2010-12-07 23:40:40
Ah, goodness. Git seems to be regularly messing up my commits.
I suppose it is because of line endings, but I've double-checked and they seem to be proper Unix line breaks on my working copy. Could somebody please double-check this?
Yes, make it "on" by default.
In profile.php (line 1582), it should be || and not &&.
Franz 2010-12-08 09:50:55
Thanks, fixed. Any clue about the linebreaks thing?
Reines 2010-12-08 09:52:51
What editor are you using, and are you using msysgit? If so, what setting did you choose for line endings?
Franz 2010-12-08 12:32:04
Yup, msysgit it is. I chose "checkout as-is, commit as-is".
I typically use Notepad2 or Aptana 2. Notepad2 told me it was Unix linebreaks.