Fork me on GitHub
Subscribe 3

Ticket #1073 (fixed task)

Wrong DBlayer constructors

  • Created: 2016-01-06 18:59:29
  • Reported by: artoodetoo
  • Assigned to: Franz
  • Milestone: 1.6
  • Component: database
  • Priority: low

Please look at https://github.com/fluxbb/fluxbb/blob/m … ql.php#L52

Constructor __construct() returns something.
D'oh... Where can I get this?

Below is another (!!!) old style constructor which is DEPRECATED in PHP 7.0.
What is more important for you: PHP7 or PHP4?

History

artoodetoo 2016-01-06 19:17:15

  • Description changed. (Diff)

Studio384 2016-01-07 21:37:23

It's deprecated, not removed. If we had to kick out everything that is deprecated than we could only support PHP7. Something being deprecated is not a reason to just drop it. MySQL has been deprecated for years in favor of MySQLi, still no reason to drop it just like that, though. But sure, support for PHP4 is indeed fully unnecessary.

artoodetoo 2016-01-08 08:28:12

To be honest, there is no reason to keep support deprecated things other than PHP4. Do you need it?

Support for PHP 4 has been discontinued since 2007-12-31.

I advice to create "fluxbb-heavy-legacy" branch or fork for a dozen people who need PHP4. They shouldn't be a milestone round fluxbb's neck.

Comment edited 2 times (Diff, Diff 2)

Studio384 2016-01-09 19:47:01

My point was simply that he stated that because it was deprecated in 7.0, it should be removed out of FluxBB. Plenty of things that FluxBB uses are deprecated, no reason to rewrite all of it just for the sake of it. These things should go when we drop support for older versions of PHP or if it is removed in future versions and thus cannot be used anymore. As it stands now, we still support PHP 4.4, how ridiculous that may be. 1.6 and up won't.

artoodetoo 2016-01-09 20:31:52

What about constructor returning value, can you justify it too?

Franz 2016-01-10 12:31:09

No, that's simply pointless. smile

artoodetoo 2016-01-10 12:39:32

Exactly! Pointless. For years. Let's cure selective blindness.

Franz 2018-07-19 10:39:20

  • Milestone set to 1.6.

artoodetoo 2018-07-19 19:02:36

hurray! perhaps in v1.6 it will be fixed at last.

Franz 2018-07-19 21:55:54

  • Owner set to Franz.

Franz 2018-07-19 22:04:16

  • Status changed from open to fixed.

Commit ad78691 to fluxbb 1.6-next

Constructors: Get rid of old ones and return values

The old syntax is no longer needed for PHP4 compatibility, and the
return values never made sense in the first place.

Fixes #1073.