Fork me on GitHub
Subscribe 1

Ticket #1001 (fixed bug)

Remove setting of values in quickpostform

  • Created: 2014-12-06 08:35:52
  • Reported by: Visman
  • Assigned to: quy
  • Milestone: 1.5.8
  • Component: code
  • Priority: normal
						<label class="conl required"><strong><?php echo $lang_post['Guest name'] ?> <span><?php echo $lang_common['Required'] ?></span></strong><br /><input type="text" name="req_username" value="<?php if (isset($_POST['req_username'])) echo pun_htmlspecialchars($username); ?>" size="25" maxlength="25" tabindex="<?php echo $cur_index++ ?>" /><br /></label>
						<label class="conl<?php echo ($pun_config['p_force_guest_email'] == '1') ? ' required' : '' ?>"><?php echo $email_label ?><br /><input type="text" name="<?php echo $email_form_name ?>" value="<?php if (isset($_POST[$email_form_name])) echo pun_htmlspecialchars($email); ?>" size="50" maxlength="80" tabindex="<?php echo $cur_index++ ?>" /><br /></label>

The variables $username and $mail are defined in post.php. In the vievtopic.php they are not defined.

History

Visman 2014-12-06 08:39:33

Hmm. They then none at all when not in use!

quy 2014-12-06 15:30:51

  • Milestone set to 1.5.8.
  • Owner set to quy.

quy 2014-12-06 15:57:00

Commit d446317 to fluxbb 1.5-next

#1001: Remove unnecessary setting of values in quickpostform

Franz 2014-12-06 16:21:42

Commit db40266 to fluxbb 1.5-next

Merge pull request #125 from Quy/1001-quickpost

#1001: Remove unnecessary setting of values in quickpostform

quy 2014-12-06 16:25:14

  • Status changed from open to fixed.
  • Summary changed from Error in the form of a message in viewtopic.php to Remove setting of values in quickpostform.

Good catch! Thanks Visman.

quy 2014-12-06 20:08:48

Commit 5c7cb27 to fluxbb 1.5-next

#1001: Remove empty value attributes

quy 2014-12-06 20:20:19

Commit 140efd0 to fluxbb 1.5-next

Merge pull request #126 from Quy/1001-value-attribute

#1001: Remove empty value attributes