Fork me on GitHub
Subscribe 3

Ticket #100 (fixed enhancement)

wordwrap should be enabled on posts

  • Created: 2010-08-13 19:06:59
  • Reported by: hassan-c
  • Assigned to: Reines
  • Milestone: 1.4.3
  • Component: usability
  • Priority: normal

Shown here: http://fluxbb.org/forums/viewtopic.php?id=4526

This can either be done using the PHP wordwrap() function or using CSS3 word-wrap:break-word;

CSS3 solution seems to work better, but not all browsers of course support CSS3 yet.

History

davidlougheed 2010-08-13 20:40:00

Actually, CSS3 word-wrap is apparently supported on all major browsers.

http://www.impressivewebs.com/word-wrap-css3/

I'll try to create a patch, but I'm not that experienced with the Pun/FluxBB code base.

davidlougheed 2010-08-13 21:09:15

Found the source of the problem, I'm now fixing styles.

davidlougheed 2010-08-13 21:20:57

Fixed. Now to figure out github...

davidlougheed 2010-08-14 13:34:00

And finally, sent a pull request.

Reines 2010-08-14 15:35:02

  • Milestone set to 1.4.3.
  • Owner set to Reines.

Looks good cheers. Your committer username is currently set to "System Administrator". Could you change it to something more sensible and reapply the commit and I'll merge it? Otherwise I'll just manually apply it with my own username and credit you in the commit log.

davidlougheed 2010-08-14 16:25:14

I can't get some of the things to change, so can you just manually apply it and credit me? I've got all but 3 to change names.

davidlougheed 2010-08-14 16:40:46

Ill send a pull request anyway, it might be a browser cache problem...

Franz 2010-08-14 16:43:31

Jamie: can't you enter the Author name manually on commit?

Reines 2010-08-14 17:14:42

  • Status changed from open to fixed.

Fixed in 0da4d88369f248c3c26c.

I put the word-wrap into .postmsg rather than the global section you used so it only affects posts, not the rest of the forum.

Reines 2010-08-14 17:15:54

Commit 0da4d88 to fluxbb fluxbb-1.4

Fixing non-wrapping of words in posts. Found and fixed by davidlougheed. #100

davidlougheed 2010-08-14 17:54:08

Sorry about my mistakes, I'm only 13 wink