You are not logged in.
- Topics: Active | Unanswered
Pages: 1
#1 2010-02-03 15:32:30
- daris
- Developer
- From: Poland
- Registered: 2008-05-09
- Posts: 514
Selected item in navlinks
Will be in FluxBB 1.4 class="active" on selected list item in navigation links at top of page like in 1.3?
Sorry for my English ;p
Polish FluxBB support | FluxBB 1.4 styles | Mods for FluxBB
Offline
#2 2010-02-06 14:21:27
- orkneywd
- Member
- Registered: 2008-05-10
- Posts: 96
Re: Selected item in navlinks
I was wondering about this too 
There is class="isactive" but its only used on Profile and Admin menus.
Could this be added to the navigation links in the core also? Good for usability I think
Offline
#3 2010-02-06 23:25:07
- quy
- Developer
- From: California
- Registered: 2008-05-09
- Posts: 735
Re: Selected item in navlinks
Added in changeset 1351.
Offline
#4 2010-02-06 23:50:27
- Paul
- Developer
- From: Wales, UK
- Registered: 2008-04-27
- Posts: 1,623
Re: Selected item in navlinks
It looks to me on that setup that index is only active if you are on the index page. Shouldn't index be the active link for any page that descends from it and doesn't have its own menu item, basically any page with breadcrumbs. If not then if you are on viewforum or viewtopic there is no active menu item. Either there is always an active item or never an active item.
An alternative way of doing it would be
define('FORUM_ACTIVE_PAGE', 'whatever')
And then used the same value on descendant pages e.g. index, viewforum and viewtopic would all have been 'index' and all profile pages would simply be 'profile' as would sub-forms such as change password, avatar upload etc.
The only thing worse than finding a bug is knowing I created it in the first place.
Offline
#5 2010-02-07 02:41:02
- quy
- Developer
- From: California
- Registered: 2008-05-09
- Posts: 735
Re: Selected item in navlinks
Your way is much better. Changed in 1353. Thanks.
Offline
#6 2010-02-07 09:07:49
- daris
- Developer
- From: Poland
- Registered: 2008-05-09
- Posts: 514
Re: Selected item in navlinks
Why did you use FORUM prefix instead of PUN?
Sorry for my English ;p
Polish FluxBB support | FluxBB 1.4 styles | Mods for FluxBB
Offline
#7 2010-02-07 16:05:08
- quy
- Developer
- From: California
- Registered: 2008-05-09
- Posts: 735
Re: Selected item in navlinks
Changed in 1356. Thanks.
Offline
#8 2010-02-07 18:31:11
- Franz
- Lead developer
- From: Germany
- Registered: 2008-05-13
- Posts: 3,755
- Website
Re: Selected item in navlinks
There is no reason to use PUN_ for a new constant. We already have a mix of PUN_* and FORUM_* constants (some new ones in v1.4), so there is absolutely no need to use a pointless prefix like PUN_ on FluxBB 
Offline
#9 2010-02-07 19:00:18
- Paul
- Developer
- From: Wales, UK
- Registered: 2008-04-27
- Posts: 1,623
Re: Selected item in navlinks
But please don't change it back again.
The only thing worse than finding a bug is knowing I created it in the first place.
Offline
Pages: 1