Paginate

Xzorg6 · 2009-06-30 19:36:33

Hi,

Can you add the same paginate function in 1.4 as in 1.3 ?
I means with the "previous" and "next" links.

Besides, it's useful for the forum to be compatible with firefox extension AutoPager.

Actually, I mods my 1.2 forum like this :

function paginate($num_pages, $cur_page, $link_to)
{
    $pages = array();
    $link_to_all = false;

    // If $cur_page == -1, we link to all pages (used in viewforum.php)
    if ($cur_page == -1)
    {
        $cur_page = 1;
        $link_to_all = true;
    }

    if ($num_pages <= 1)
        $pages = array('<strong>1</strong>');
    else
    {
        // Add a previous page link
        if ($num_pages > 1 && $cur_page > 1)
        {            
            $pages[] = '<a href="'.$link_to.'&amp;p='.($cur_page-1).'">&laquo;</a>';
        }    
                        
        if ($cur_page > 3)
        {
            $pages[] = '<a href="'.$link_to.'&amp;p=1">1</a>';

            if ($cur_page != 4)
                $pages[] = '&hellip;';
        }

        // Don't ask me how the following works. It just does, OK? :-)
        for ($current = $cur_page - 2, $stop = $cur_page + 3; $current < $stop; ++$current)
        {
            if ($current < 1 || $current > $num_pages)
                continue;
            else if ($current != $cur_page || $link_to_all)
                $pages[] = '<a href="'.$link_to.'&amp;p='.$current.'">'.$current.'</a>';
            else
                $pages[] = '<strong>'.$current.'</strong>';
        }

        if ($cur_page <= ($num_pages-3))
        {
            if ($cur_page != ($num_pages-3))
                $pages[] = '&hellip;';

            $pages[] = '<a href="'.$link_to.'&amp;p='.$num_pages.'">'.$num_pages.'</a>';
        }
        // Add a next page link
        if ($num_pages > 1 && !$link_to_all && $cur_page < $num_pages)
        {            
            $pages[] = '<a href="'.$link_to.'&amp;p='.($cur_page+1).'">&raquo;</a>';
        }    
    }

    return implode('&nbsp;', $pages);
}

Signs avoid to change language files.

Thanks

Mpok · 2009-07-01 06:44:00

Didn't look at the code above, but i aggree on the feature : "next" and "previous" links are an easy feature to implement, and SO MUCH appreciated by users...

Xzorg6 · 2009-07-16 19:04:04

No response from the dev team...

FSX · 2009-07-16 21:07:13

Will be added soon.

Xzorg6 · 2009-07-16 21:12:10

Thanks a lot

Koos · 2009-07-19 11:14:45

Please reconsider the use of the previous/next links in pagination. I think it's bit of an eyesore and takes up too much space:

Previously:

Now:

And when you've got many pages:

Previously:

Now:

Xzorg6 · 2009-07-19 11:26:40

You can change the word in the language file if you want...

I use signs « and » on my forum : Example
As I say on the first post.

Thus, in some language, as french words ("Précédente" and "Suivante"), that takes more space.

Last edited by Xzorg6 (2009-07-19 11:35:28)

Koos · 2009-07-20 16:27:49

Thanks for your response Xzorg6, but I am talking about the default forum behavior.

MattF · 2009-07-20 18:31:13

Would it not be better to make the default as was with the new format being a selectable option? Personally, I agree with Koos. I much prefer the old format.

Koos · 2009-07-23 20:50:33

So has a final decision been taken on this matter?

trichome · 2009-07-23 21:53:44

Maybe just add in some classes so the links can be hidden/styled via CSS?

xSDMx · 2009-07-25 19:34:12

Just keep the original, and add a small entry field for the page to the right of the numbers - everyone wins!

Paul · 2009-07-25 20:58:06

I think next and previous links have become standard. I certainly expect to see them whenever I'm viewing paginated content. If they are too verbose in some languages then its just a matter of substituting + and - in the langauge file or whatever symbol you happen to prefer (laquo and raquo or not really a good idea as I think most people would read those as first and last, better just to use < and >).

MattF · 2009-07-26 21:31:54

Paul wrote:

I think next and previous links have become standard. I certainly expect to see them whenever I'm viewing paginated content. If they are too verbose in some languages then its just a matter of substituting + and - in the langauge file or whatever symbol you happen to prefer (laquo and raquo or not really a good idea as I think most people would read those as first and last, better just to use < and >).

They're obviously stopping in, by the sounds of it, so would it not be best to at least put them in span tags or suchlike, (if they aren't already), so that they can at least be hidden if desired?

quy · 2009-07-27 14:47:09

MattF wrote:

...so that they can at least be hidden if desired?

Change the language entries for Previous/Next links to an empty string.

Paul · 2009-07-27 15:31:50

Mattf: in the end it will be upto the devs whether they stay in or not. I was just offering an opinion.

MattF · 2009-07-27 17:10:43

qubertman wrote:

MattF wrote:
...so that they can at least be hidden if desired?
Change the language entries for Previous/Next links to an empty string.

That's my muppet moment for the week highlighted and done.

Paul wrote:

Mattf: in the end it will be upto the devs whether they stay in or not. I was just offering an opinion.

Apologies. I thought you were still the one who had final say on all things markup related.

Just out of curiosity, what other benefits, (other than the obvious visual markers), do those prev/next links have?

Paul · 2009-07-27 18:31:27

A large target area to hit. That of course could be remedied by making the numbered links larger like 1.3. I think there is a possible accessibility benefit where there is a large number of pages. Somebody using a screenreader might loose track of which page they are on and if that happens hitting next solves the problem.

Changing the language strings to empty is not a good idea, not unless the generation of the links was made conditional upon the langauge string having a value. Otherwise you would end up with an empty link tag. I would actually prefer making them vanish with css which leaves them in place for screenreaders and text browsers. If the link tag were given a class then it would also be possible to substitute a background img (an arrow or something) as well as making them vanish. You just give the link zero width which removes the text and enough left/right padding for the graphic.

MattF · 2009-07-28 04:12:32

Cheers for that explanation Paul.

Koos · 2009-08-15 17:59:05

Paul wrote:

I think next and previous links have become standard. I certainly expect to see them whenever I'm viewing paginated content. If they are too verbose in some languages then its just a matter of substituting + and - in the langauge file or whatever symbol you happen to prefer (laquo and raquo or not really a good idea as I think most people would read those as first and last, better just to use < and >).

That would look much better - if 'Previous' and 'Next' in the lang file could just be replaced with < and > as you mentioned. Invision Power Board and vBulletin also display their previous and next links by using < and >. Could this change perhaps be made in the core?

Koos · 2009-08-24 15:45:39

Would be nice to hear other peoples thoughts on this. Like I said above: I think using < and > for the previous and next links would look much cleaner and take up less space.

Compare:

with:

Forums

#1 2009-06-30 19:36:33

Paginate

#2 2009-07-01 06:44:00

Re: Paginate

#3 2009-07-16 19:04:04

Re: Paginate

#4 2009-07-16 21:07:13

Re: Paginate

#5 2009-07-16 21:12:10

Re: Paginate

#6 2009-07-19 11:14:45

Re: Paginate

#7 2009-07-19 11:26:40

Re: Paginate

#8 2009-07-20 16:27:49

Re: Paginate

#9 2009-07-20 18:31:13

Re: Paginate

#10 2009-07-23 20:50:33

Re: Paginate

#11 2009-07-23 21:53:44

Re: Paginate

#12 2009-07-25 19:34:12

Re: Paginate

#13 2009-07-25 20:58:06

Re: Paginate

#14 2009-07-26 21:31:54

Re: Paginate

#15 2009-07-27 14:47:09

Re: Paginate

#16 2009-07-27 15:31:50

Re: Paginate

#17 2009-07-27 17:10:43

Re: Paginate

#18 2009-07-27 18:31:27

Re: Paginate

#19 2009-07-28 04:12:32

Re: Paginate

#20 2009-08-15 17:59:05

Re: Paginate

#21 2009-08-24 15:45:39

Re: Paginate

Board footer