FluxBB Forums

Unfortunately no one can be told what FluxBB is - you have to see it for yourself.

You are not logged in.

Announcement

FluxBB 1.4.2 and FluxBB 1.2.23 are released, fixing a critical vulnerability in PHP's unserialize() function. Please upgrade ASAP.

#1 2009-06-26 23:16:51

Smartys
Former developer
Registered: 2008-04-27
Posts: 2,878
Website

Missing element in RSS feeds

RSS feeds should have a guid element for each item. That way, RSS readers don't duplicate items. 1.3 does this.

http://cyber.law.harvard.edu/rss/rss.ht … OfLtitemgt

Offline

#2 2009-06-27 00:59:24

MattF
Member
From: South Yorkshire, England
Registered: 2008-05-06
Posts: 1,129
Website

Re: Missing element in RSS feeds

Might it also be worthwhile adding the 'atom:link rel="self"' tag too?


Screw the chavs and God save the Queen!

Offline

#3 2009-06-27 05:58:05

Smartys
Former developer
Registered: 2008-04-27
Posts: 2,878
Website

Re: Missing element in RSS feeds

Offline

#4 2009-06-27 11:02:46

MattF
Member
From: South Yorkshire, England
Registered: 2008-05-06
Posts: 1,129
Website

Re: Missing element in RSS feeds

That's the one. smile


Screw the chavs and God save the Queen!

Offline

#5 2009-07-01 07:14:47

Mpok
Member
From: France
Registered: 2008-05-12
Posts: 168

Re: Missing element in RSS feeds

There is a validation tool for RSS : http://feedvalidator.org/

If the fluxbb feed passes it (totally, meant not even a warning), that's ok..
(not tested myself on 1.4)

Offline

#6 2009-07-02 05:47:26

xSDMx
Member
Registered: 2008-06-24
Posts: 125

Re: Missing element in RSS feeds

You just need to add this to 1.2:

echo
"\t\t".'<guid>'.$pun_config['o_base_url'].'/viewtopic.php?id='.$cur_topic['id'].$url_action.'</guid>'."\r\n";

In extern.php - for 1.4 it might be slightly different, but it's an extremely easy fix. You need to do this or else Opera and other crappy RSS readers will improperly read your feeds.

Offline

#7 2009-07-02 05:47:57

xSDMx
Member
Registered: 2008-06-24
Posts: 125

Re: Missing element in RSS feeds

Mpok wrote:

There is a validation tool for RSS : http://feedvalidator.org/

If the fluxbb feed passes it (totally, meant not even a warning), that's ok..
(not tested myself on 1.4)

Even if it passes, that doesn't mean it works correctly.

Offline

#8 2009-07-02 13:58:25

MattF
Member
From: South Yorkshire, England
Registered: 2008-05-06
Posts: 1,129
Website

Re: Missing element in RSS feeds

True, but it's an indication of its validity where the standards are concerned. smile Personally, I prefer the Validome validator for testing XML and suchlike.

http://www.validome.org/


Screw the chavs and God save the Queen!

Offline

#9 2009-07-02 18:18:06

xSDMx
Member
Registered: 2008-06-24
Posts: 125

Re: Missing element in RSS feeds

To get it to work 100%, you just need to add that bit of code and the Atom links and you're compatible with everything. Convert it to 2.0 and add the RSS icon to your header, and you've got the best RSS solution around.

Offline

#10 2009-07-02 19:24:07

MattF
Member
From: South Yorkshire, England
Registered: 2008-05-06
Posts: 1,129
Website

Re: Missing element in RSS feeds

Be even better if it had Atom output too. big_smile


Screw the chavs and God save the Queen!

Offline

#11 2009-07-08 18:04:52

quy
Developer
From: California
Registered: 2008-05-09
Posts: 612

Re: Missing element in RSS feeds

Ported extern.php from v1.3 in r1073.

Offline

#12 2009-07-08 20:22:33

hcgtv
Member
From: Charlotte, NC
Registered: 2008-05-08
Posts: 391
Website

Re: Missing element in RSS feeds

qubertman wrote:

Ported extern.php from v1.3 in r1073.

Nice, thanks.


Bert Garcia - When all you have is a keyboard

Offline

Board footer

Powered by FluxBB 1.4.2