Guests online text + little improvement on user count

vincent · 2008-08-01 22:56:39

Hello,

In lang/index.php we have 'Users plural', 'User single' and 'Users none' that's great, but we should also have a 'Guest none'.

Because I think "There are 0 guests and.." shoud be "There are 0 guest and..." or "There are no guest and..."

Perhaps by replacing this :

<?php (($num_guests != 1) ? printf($lang_index['Guests plural'], forum_number_format($num_guests)) : printf($lang_index['Guest single'], $num_guests)) ?>

by something like this :

<?php 
    if ($num_guests < 1)
        printf($lang_index['Guest none'], $num_guests);
    elseif ($num_guests == 1)
        printf($lang_index['Guest single'], $num_guests);
    else
        printf($lang_index['Guests plural'], forum_number_format($num_guests));
    ?>

By the way, I think this piece of code :

<?php ((count($users) > 1) ? printf($lang_index['Users plural'], forum_number_format(count($users))) : printf(((count($users) == 0) ? $lang_index['Users none'] : $lang_index['User single']), count($users))) ?>

Should be replace by a similare piece than the one for pluralize the guest count. A variable could be added just before 'in_users_online_pre_online_info_output' hook.

$num_users = count($users);

[...]

<?php 
    if ($num_users < 1)
        printf($lang_index['Users none'], $num_users);
    elseif ($num_users == 1)
        printf($lang_index['User single'], $num_users);
    else
        printf($lang_index['Users plural'], forum_number_format($num_users));
    ?>

So like this we could have just one count($users) and the possibilty to use this number in previous hook, plus the possibility to use textual for "none" and "one" like "... and one registered user online"

Last edited by vincent (2008-08-01 22:58:40)

Smartys · 2008-08-01 23:13:07

Moved to Feature requests, since this isn't a bug.
You are grammatically incorrect: you don't use a plural verb (are) and a singular object (guest).

vincent · 2008-08-01 23:37:35

yes your right ! I'm not speak English very well and I just past the text from the forum, so I think it is not a feature request but a bug

because 0 (zero) isn't plural ; isn't it ?

Ce qui est sûr c'est qu'en français "Il y a 0 invités" c'est grammaticalement une erreur également.

Last edited by vincent (2008-08-01 23:39:26)

Smartys · 2008-08-01 23:47:07

Zero is plural in many languages
http://en.wikipedia.org/wiki/Plural

Languages having only a singular and plural form may still differ in their treatment of zero. For example, in English, German, Dutch, Italian, Spanish and Portuguese, the plural form is used for zero or more than one, and the singular for one thing only. By contrast, in French, the singular form is used for zero.

vincent · 2008-08-01 23:51:50

no, in french we write "Il y a 0 invité" et "Il y a 2 invités" but we prefere wrinting "Il n'y a aucun invité" (for zero guest)

Smartys · 2008-08-01 23:53:33

Yes, that's exactly what I said.

vincent · 2008-08-02 00:17:14

hm, so we said the same thing but I'm not sure.

Two forms could claim our needs in french (singular/plural) :

singular :

in french :
- "Il y a 0 invité"
- "Il y a 1 invité"

in English :
- "There is 0 guest"
- "There is 1 guest"

plural :

in french :
- "Il y a X invités"

in English :
- "There are X guests"

But actually forums display :

singular :
- "There is 1 guest"

plural :
- "There are 0 guests"
- "There are X guests"

In french 0 IS singular NOT plural. So we have a problem.

So for more flexibility and because wikipedia say some languages use pural for zero and other use singular (like in french) I suggest 3 forms :
none/singular/plural

0 = "Il n'y a aucun invité" or "Il y a 0 invité" / "There is no guest" or "There are 0 guests"
1 = "Il y a un invité" or "Il y a 1 invité" / "There is one guest" or "There is 1 guest"
X = "Il y a X invités" / "There are X invité"

damaxxed · 2008-08-02 01:52:16

That's the best solution for i18n: 3 Strings (as reference: Wordpress does it exactly like that):

0 Guests
1 Guest
% Guests

Pandark · 2008-08-02 02:02:37

Yes.
Which in French does:

0 invité (or aucun invité)
1 invité
% invités

Last edited by Pandark (2008-08-02 02:05:16)

artoodetoo · 2008-08-02 03:33:36

just for example in Russian (latin transliteration):

0 gostej or net gostej (plural #1)
1 gost' (single)
2 gostia (plural #2)
3 gostia
4 gostia
5 gostej (plural #1)
...
21 gost' (is it plural or single?)
22 gostia
... etc. last digit is rule

artoodetoo · 2008-08-02 03:39:48

Some of webmasters puts function definitions to language files to solve language specific number|gender variations. Probably, it is unique solution.

Paul · 2008-08-02 04:30:44

I've tinkered with this as much as I'm going to. It should now be ok for most langauges and is more extensible.

vincent · 2008-08-02 09:40:56

yeah ! merci

FluxBB Forums

Announcement

#1 2008-08-01 22:56:39

Guests online text + little improvement on user count

#2 2008-08-01 23:13:07

Re: Guests online text + little improvement on user count

#3 2008-08-01 23:37:35

Re: Guests online text + little improvement on user count

#4 2008-08-01 23:47:07

Re: Guests online text + little improvement on user count

#5 2008-08-01 23:51:50

Re: Guests online text + little improvement on user count

#6 2008-08-01 23:53:33

Re: Guests online text + little improvement on user count

#7 2008-08-02 00:17:14

Re: Guests online text + little improvement on user count

#8 2008-08-02 01:52:16

Re: Guests online text + little improvement on user count

#9 2008-08-02 02:02:37

Re: Guests online text + little improvement on user count

#10 2008-08-02 03:33:36

Re: Guests online text + little improvement on user count

#11 2008-08-02 03:39:48

Re: Guests online text + little improvement on user count

#12 2008-08-02 04:30:44

Re: Guests online text + little improvement on user count

#13 2008-08-02 09:40:56

Re: Guests online text + little improvement on user count

Board footer