merge hook names

Vovochka · 2008-05-12 21:31:21

Could you please add ability to write

        <hook id="hook1,hook2">
        </hook>

Smartys · 2008-05-12 21:33:13

You should really give an example of why you think we should add this feature/why it would be useful to have.

elbekko · 2008-05-12 21:34:55

I can give plenty. For example my smiley list extension.

Vovochka · 2008-05-12 21:37:56

elbekko wrote:

I can give plenty. For example my smiley list extension.

Aha! I'm just looking at it

Vovochka · 2008-05-12 21:41:34

And another situation:
You need code that is executed only on some pages. Now some mod writes put this code in function & place in co_common. So in moded forum there can be a lot of useless rubbish.
I would even say, it's better to be able to do like this:

    <hook id="hook1,hook2">
    </hook>

    <hook id="hook2,hook3">
    </hook>

Lamonte · 2008-05-13 16:49:28

Ah nice idea (might use this idea for a project), I see what you mean, some extensions might need to be displayed on different pages without having duplicate content(e.g.: space wastage when your copying/pasting the code multiple times to work on different parts of a forum) which would be useful if you can allow multiple hooks for extensions

Vovochka · 2008-05-13 17:55:41

Connor is going to make it
http://fluxbb.org/trac/ticket/15

Thanks, Connor

elbekko · 2008-05-13 18:13:57

Great

Connor · 2008-05-13 18:55:44

Yeh, I'm just waiting so Smartys can commit code to add priorities to hooks

Vovochka · 2008-05-13 19:25:06

But aren't they already added?
http://fluxbb.org/trac/changeset/111

upd:
and even one misprint
http://fluxbb.org/trac/changeset/115

Last edited by Vovochka (2008-05-13 19:27:06)

Connor · 2008-05-13 20:06:40

Ok, i'm just being stupid then, I'll do that next.

Vovochka · 2008-05-14 09:35:59

This extension can't be installed

<?xml version="1.0" encoding="utf-8"?>

<extension engine="1.0">
    <id>test</id>
    <title>test</title>
    <version>0</version>
    <description>test</description>
    <author>test</author>
    <minversion>1.3 Beta</minversion>
    <maxtestedon>1.3 Beta</maxtestedon>
    <hooks>
        <hook id="hd_viewforum_head,hd_viewtopic_head,hd_index_head"><![CDATA[
            // test
        ]]></hook>

        <hook id="hd_index_head"><![CDATA[
            // he-he-he
        ]]></hook>
    </hooks>
</extension>

shedrock · 2008-05-14 10:10:25

[Please don't post off-topic: thanks]

Last edited by Smartys (2008-05-14 10:42:36)

Connor · 2008-05-14 11:00:25

Vovochka wrote:

This extension can't be installed

<?xml version="1.0" encoding="utf-8"?>

<extension engine="1.0">
    <id>test</id>
    <title>test</title>
    <version>0</version>
    <description>test</description>
    <author>test</author>
    <minversion>1.3 Beta</minversion>
    <maxtestedon>1.3 Beta</maxtestedon>
    <hooks>
        <hook id="hd_viewforum_head,hd_viewtopic_head,hd_index_head"><![CDATA[
            // test
        ]]></hook>

        <hook id="hd_index_head"><![CDATA[
            // he-he-he
        ]]></hook>
    </hooks>
</extension>

No, you can only use each hook once in an extension

Vovochka · 2008-05-14 11:22:32

Connor wrote:

No, you can only use each hook once in an extension

I know. That's why I requested this feature

Connor · 2008-05-14 14:23:58

The answer is probably no

Smartys · 2008-05-14 14:25:12

No, that would complicate things a great deal. Personally, I don't see why a function can't just be used, but meh.

Lamonte · 2008-05-14 15:37:24

A function could be used, but still its extra code for a extra 3 lines -.-..(e.g. hook start function hookend,depending on your style of code)

Last edited by Lamonte (2008-05-14 15:37:42)

Forums

#1 2008-05-12 21:31:21

merge hook names

#2 2008-05-12 21:33:13

Re: merge hook names

#3 2008-05-12 21:34:55

Re: merge hook names

#4 2008-05-12 21:37:56

Re: merge hook names

#5 2008-05-12 21:41:34

Re: merge hook names

#6 2008-05-13 16:49:28

Re: merge hook names

#7 2008-05-13 17:55:41

Re: merge hook names

#8 2008-05-13 18:13:57

Re: merge hook names

#9 2008-05-13 18:55:44

Re: merge hook names

#10 2008-05-13 19:25:06

Re: merge hook names

#11 2008-05-13 20:06:40

Re: merge hook names

#12 2008-05-14 09:35:59

Re: merge hook names

#13 2008-05-14 10:10:25

Re: merge hook names

#14 2008-05-14 11:00:25

Re: merge hook names

#15 2008-05-14 11:22:32

Re: merge hook names

#16 2008-05-14 14:23:58

Re: merge hook names

#17 2008-05-14 14:25:12

Re: merge hook names

#18 2008-05-14 15:37:24

Re: merge hook names

Board footer