Discussion on 1.4 (Page 1 of 2)

If it's a drop in replacement, where 1.4 is not delayed much more, then I vote for yes.

As for the styles, just a quick readme or instructions to update your site is plenty.

What are the other thing or two that was being discussed?

Sounds like feature creep to me.

But if implementing the 1.3 parser only has minor CSS implications, I guess that's OK.

But if it has other implications for 1.4's code compatibility with 1.2, that may not be OK.

You don't want to end up with a mess - part 1.2, a bit of 1.3, and bits of new 1.4 , but which works with neither 1.2 or 1.3.

@Mpok:
Well, I don't see how a toolbar mod would break due to the inner workings of the parser changing. The BBCode won't change or anything, just how it is handled. Putting in the new parser is basically plug and play, and Paul has the code done already for a personal project.

Now, I can take a look at PunToolbar for you, but I have a feeling it won't break a thing. If it does, it's probably made in the wrong way

@sirena:
I wouldn't call it feature creep, it's just a few thoughts we want the opinion of the community on As I said, it should be basically plug and play, so no code other than the parser would change.

Just I hope in css not use a minus(negative) values(positions).

I've been following punbb/fluxbb for a long time now and just now decided to register and say I agree with hcgtv that if its a drop in replacement that doesn't delay 1.4 much more then my vote is yes.

If the 1.3 parsers is built-in 1.4. Spacing between paragraphs and some styling for lists, but that's only what I tested it could be more, but I think not.

Yes, but as FSX said, there is also a slight issue with paragraphs that needs to be fixed. Still, the style changes would be very minor, and could probably be put in base.css so custom styles don't break.

Anyway, I  tested both versions myself and looked at other forums and 1.3 always seemed faster, though it's more complicated

I vote no.

For starters its feature creep and you promised this would not happen. And besides, the 1.2 parser code is smaller, cleaner and much more readable than 1.3, particularly with regard to the implementation of regular expressions (e.g. Just take a look at the preparse_bbcode() function for comparison). The few regexes that I took a close look at in the 1.3 parser were poorly written at best. (This is one of the main reasons I abandoned using 1.3). Note that the 1.3 parser has twice the bloat (28KB vs 14KB) and yet is poorly commented.

The 1.2 code is superior IMHO. Its not broken, don't fix it!

Yes, if 1.2 is broken, by all means, fix it. Does 1.2 actualy generate invalid markup? Or is it just that it does not give you enough hooks for CSS styling? What exactly is the problem with the ALT attribute of the IMG tag?