You are not logged in. Please login or register.

Forums

Unfortunately no one can be told what FluxBB is - you have to see it for yourself.

You are not logged in.

Pages: 1 2 3 4 Next

#1 Re: Core development » 2.0 Coding Conventions » 2011-12-05 21:29:01

Gil
Reines wrote:
adaur wrote:

I personally hate braces for one-line conditionals, they're just useless and make the code dirty.

They aren't useless - they are consistent, and make it much easier to modify the body of the condition without forgetting to add them and messing it up. Personally I've never had that problem, but it is one argument that is often given for using them.

Agree. After several year of doing tests of complex system, testing code of large teams and searching bugs, we learn to love - and to impose - braces wink And the notion of project conventions too, whatever they are!

I think this example:

adaur wrote:
if (!$pun_user['is_guest']) {
$forum_actions[] = '<a href="misc.php?action=markread">'.$lang->t('Mark all as read').'</a>';
}

is awful, but not because of the braces: because of the lack of indentation smile
Without braces, I hope you write like this:

if (!$pun_user['is_guest'])
   $forum_actions[] = '<a href="misc.php?action=markread">'.$lang->t('Mark all as read').'</a>';

and not:

if (!$pun_user['is_guest'])
$forum_actions[] = '<a href="misc.php?action=markread">'.$lang->t('Mark all as read').'</a>';

For the rules : as many rules as people... Be free for your personal works, but please, for a team project, please accept conventions, even you don't like one of them...
Tabs/space is like indent style: the most awful thing is the mix of several solutions or styles!

#2 Re: General support (1.4) » CSS question, size for the leftbox. » 2011-12-03 23:20:40

Gil

You should change several values, for example:

.pun .blockpost .postbody, .pun .blockpost .postfoot {
	border-left-style: solid;
	border-left-width: 1px;
	float: right;
	margin-right: -182px;            /* -218 --> -182 ; common for left and right*/
	position: relative;
	text-align: left;
	width: 100%;
}

.pun .blockpost .postleft, .pun .blockpost .postfootleft {
	width: 170px;                  /* 206 --> 170*/
	padding: 7px 0 7px 12px;
	float: left;
	margin-left: -182px;            /* -218 --> -182 */
	position: relative;
}

and

.pun .blockpost .postright {
	position: relative;
	padding: 4px 194px 7px 18px;       /* 230 --> 194*/
}

and certainly several others class padding or width (each "230" and "206" pixel lengths)

#3 Re: General support (1.4) » CSS question, size for the leftbox. » 2011-12-03 17:33:38

Gil

You should try to change the dimensions of the postleft class (.pun .blockpost .postleft) in the css files (Fire, Earth, Air ...)

#4 Re: Core development » PHP 5.3 » 2011-10-24 21:33:19

Gil

It's a natural evolution. PHP 5.2 is no longer supported, PHP 5.4 beta1 is released, and when flux 2.0 will be delivered, PHP 5.3 will be (at least) 3 year old...
My opinion is that it would be a bad choice not to decide to use 5.3 now. If not now, when?

#5 Re: Feature requests » Merge posts form different threads » 2011-10-07 18:36:25

Gil
Franz wrote:

And that is pretty surely in the same order as the posting date. Unless you mess with the database yourself.

Yes smile
I had to do it to reorder a merge; As it didn't work with the posting time, damn, I had to shift all the fifty post numbers!

#6 Re: Feature requests » Merge posts form different threads » 2011-10-07 06:21:51

Gil
Mark wrote:

theres already a merge topic option

But without order choice; Jack: you cannot select the final order, it is determined by the post index in the post table (and not by the date, be careful)

#7 Re: General support (1.4) » RSS Feed » 2011-08-23 17:22:05

Gil
Warrantywise wrote:

Hello,

I wonder if someone can give me any more information regarding an RSS feed.

We want to post an RSS feed on the front page of our website which the latest post from our flux forum.

If you can tell me if this is possible and has any more done this before?

Thanks,

Scott

You must include "extern.php" in your front page; For parameters, refer to the instruction in the comments of the file (forum root directory)

Note: for us, include didn't work, we had to use curl_exec (because of another subdomains?)
<?php curl_exec(curl_init("http://www.my_site.ext/extern.php?action=feed&show=11")); ?>

#8 Re: Show off » WebFantasy.Fr » 2011-08-18 13:48:10

Gil

Very good work! The only disadvantage I could see is that the update for the future fluxBB (major) versions may be a bit difficult.

Some corrections:
- the header sentence of the Terry Goodkind forum is erroneous: "Ce forum, ..., est là pour permettre aux lecteurs de Terry Goodkind et de son cycle". (verb missing)
- the "mentions légales" link doesn't work (all sites, all pages)
- Sanderson/Alcatraz: three books already published (Ed. Mango - http://www.bdfi.net/series/pages/alcatraz_smedry.php... for example wink)

#9 Re: Core development » To Template Engine Or Not - V2 » 2011-03-17 23:15:32

Gil

Just a link to a short Twig presentation: Six reasons why Twig makes my life better.

Don't get me wrong: I do not advocate the use of Twig (I never used it for the moment). But if that is possible (without strong impacts and constraints), it is better to use an existing library (this one or another) than to reinvent the wheel...

#10 Re: General support (1.4) » Put a html table in a post ? » 2011-03-13 10:16:38

Gil
Mpok wrote:
ridgerunner wrote:

Note that it currently only handles TABLE, TR and TD tags and they must be correctly nested like so

What about THEAD, TBODY and THs ?
If u implement TABLE, u have to do it fully. The tags above are REALLY important for accessibility.
U can't treat 'tables' as in 90's…

Mpok, your response is not very pleasant for Ridgerunner; He has nothing to do, he made this to help. Did you read the post ? " ... as an experiment (Just for you!) ... currently only...". So: it is experimental, and it can be improved. YOU can improve it, if you want a perfect and complete parser. And don't forget summary, caption, col and colgroup...

#11 Re: General support (1.4) » Why not a 1.4.5 (bug fixing) then 1.4.6 for enhancements? » 2011-03-11 07:42:19

Gil
Smartys wrote:

"There's a bug if you're using a version of PHP that was unsupported 3 years ago" is not a problem of a critical enough nature to break a release cycle.

I agree with you, it can be a non critical bug!
But:

  • I didn't say it is a critical one, I just say that I read "...or wait for FluxBB X"... Imho, when we are saying something like that, it seems to be better not to delay a lot before delivering the announced version

  • There is about 20 bugs fixed, and some enhancements. Why not fixing the others bugs and deliver? What about to plan another further version with not-so-needed enhancements?

  • If you speak about release cycle, you can speak about date too, and you can plan several release and can define priority. It is not mandatory to assign all enhancements and corrections in the same "the next release". The total number of tickets planned for the 1.4.5 is currently growing each week. It can be without end sad

  • I just gave my opinion, of course you are totally free wink

#12 General support (1.4) » Why not a 1.4.5 (bug fixing) then 1.4.6 for enhancements? » 2011-03-10 20:33:51

Gil
Replies: 5

Don't you think it should be better to plan/deliver two versions, a 1.4.5 version with only bug fixing, then a 1.4.6 version with enhancements (if enhancements are still requested, and if a further 1.4.6 correction version is not needed).

I know that regular deliveries is not a good habits or a good choice, but one can consider that to have a "free-bugs" version (at least blocking & important bugs) should be a a priority, and more urgent than to have a version with enhancements.

It seems to be more important as a warning message is explaining one must wait for 1.4.5 ("Warning: There is a bug in FluxBB 1.4.4 which prevents authentication when using PHP 4. PHP 4 reached end-of-life over 3 years ago, however if you still use it, we recommend you either use a development snapshot (not necessarily stable!) or wait for FluxBB 1.4.5.")

What is your opinion? Do you think it is better to have an only 1.4.5 version with all corrections and enhancements? Don't you think that there is a risk that the "todo" list (current 1.4.5 milestone) will grow more and more, so will be delayed for a very long time?

#13 Re: General support (1.4) » Put a html table in a post ? » 2011-02-27 13:36:37

Gil

You can search for syntax (and associated parser code) on others forums, then you can try to adapt the extension in a fluxBB mod; example with vBulletin: http://forum.egypt.com/enforum/mods-3-7 … -3538.html

#14 Re: FluxBB discussion » Cleaned up header - quick searches revisited » 2011-02-01 23:24:39

Gil
quy wrote:

Topics: My | New | Active | Unanswered

I don't like neither "my" nor "yours" after a name ("topics"), maybe because in french, "sujets : vôtres" ou "sujet : miens" is not very attractive (nor correct).
As "new", "active", "unanswered" are adjectives, another adjective should be better: what about "personal", or "initiated" (or other better idea...)

Topics: New | Active | Unanswered | Personal

(And IMHO I think that the "New" one should be the first one)

#15 Re: General discussion » a JSON-flatfile forum project, goobbs » 2011-01-31 19:59:29

Gil
Smartys wrote:

Excellent article, despite an enormous error (*).









(*)  What a troll! The best text editor in the world is still vi, not emacs wink

#16 Re: General discussion » Poll: Services of storage of pictures » 2011-01-08 19:07:41

Gil

If you can, I think you should use your own service, hosting images at the same place as your website. This is the best solution to have a sustainable site. The alternative is to discover a morning in a few year a lot of "red cross"...

#17 Re: Core development » 2.0: Language packs etc. (RFC) » 2011-01-08 11:23:55

Gil
Mpok wrote:

Whatever the solution u finally choose, seeing english messages text in the PHP code is BAD (except for error codes). Point. IMO.

It's not bad because it's bad wink Be able to have a clear view of the exact text is a good aim; It's bad because of reason provided by Reines, which is an ample reason. The solution is to try have a clear label for each text (or errors, imo).

Otomatic wrote:

All changes must simplify and assist the work of users. It is for the users you must direct your work, not for developers.

Agree with ur message, but not totally agree with this particular point; Yes, most changes must be for the users; but if you can find a change to simplify the code or the developers' work, you must do it!

Reines wrote:

...different formats (PHP-based, XML, INI or whatever) if needed (though I don't necessarily know if supporting different formats would be best).

Could be great for a framework, but not useful imo for a forum.

#18 Re: Core development » Site - Resources Pages » 2010-12-23 07:20:45

Gil
Mpok wrote:

@Gil : i agree with u, but all u suggest is for the devs part only (not fluxbb.org). It's up to devs of mods (including me) to provide screenshots, or better description of their mods.

Not exactly. Not 100%. Could be improved on fluxbb side.
Examples: https://fluxbb.org/resources/mods/colorize-groups/ or https://fluxbb.org/resources/mods/ajax-post-edit/.

Better: in the description, devs should be able to add true links in the description (no need of copy/paste)

Better: in the description, devs should be able to add thumbnails as links to screen-shots

Better: in the description, devs should be able to add a 'read-me' file (so description field size can be limited, read-me file being the true detailed description: what-is-it and how-to-use). OK this file can be in the zip package, but a direct access to this file should be more useful!

Better: direct access to a detailed read-me and screen-shots (need of an improved "submit new modification" form). This allows flux to change the presentation (at least to process "read-me" field (if file exists) and screen-shot field(s) (if exist), like the 'website' field.

#19 Re: Core development » Site - Resources Pages » 2010-12-22 07:10:32

Gil

It should be great to have the possibility to see (if pertinent) some screen-shots of the modifications (and, later, plug-ins & styles) before downloading, and to have more details. It should help an user to know if the mod is the correct "answer to what he is looking for. => for the developer to be able to upload screen-shots, and for the user to have a "preview" button to see what it looks (on the mod or release page, to be defined).
A "read-me" file with more details (exact functionalities, parameters...) could be great too, if needed.
I didn't say that it should be mandatory, just that for some not-so-easy mods a developer should be able to add a read-me file and screen-shots.

#20 Re: Feature requests » FluxBB automatic upgrade / automatic install » 2010-10-23 22:30:54

Gil

Up! smile (I still think it could be a good improvement)

#21 Re: Feature requests » Breadcrumbs on search results page » 2010-10-14 18:35:07

Gil
Mpok wrote:
Gil wrote:

marking the searched expression in the messages could be good too!

There is a mod for that (for 1.2.x).

I agree it could be a mod (even if it is a core or option of a lot of search function).

#22 Re: Feature requests » Breadcrumbs on search results page » 2010-10-13 19:48:57

Gil
Paul wrote:

If the breadcrumb on the search results page leads back to the search page then you won't see the search term again because the crumb is just a link which reloads the search page with a blank form.

Of course yes, but:
--> you can see the searched term ( Search >> expression ) (*)
--> When you are on page 17 on a forum, then you click to view a topic, the link to the forum in the breadcrumb is a link to the *first* page of the forum, not the page 17. It is about the same behavior.

(*) marking the searched expression in the messages could be good too!

#23 Re: Feature requests » Breadcrumbs on search results page » 2010-10-13 19:26:30

Gil
Franz wrote:

Would it make sense to have breadcrumbs on the search results page? Would be a nice way to show the search term again...

It could make sense to:

  • have breadcrumbs on all pages, search included;

  • be able to de-active breadrumb *in* the page;

  • be able to easily re-use it as an integration in a site breadcrumb (Index >> one >> two ===> Mysite >> forum >> one >> two).

tongue
To be easy to replace something like that
flux_bc_current.jpg
by something like that:
flux_bc_integration.jpg
Sorry Franz, this is a little deviation/extension of your question, but you can understand that my answer is yes!

#24 Re: General support (1.4) » Last post (viewforum.php) not seen as last in main page (index.php) » 2010-09-23 21:46:56

Gil
Reines wrote:

Did you upgrade while 1.4 was still in RC stage, or when 1.4.0 came out?

It may be worth trying to rebuild your search index and see if that helps, but it will take a while if you have a large board.

Official 1.4, but OK, I think I find the problem: on the server, I see that mysql connection collation is utf8_unicode_ci, but tables collations are latin1_swedish_ci...

On my PC, MySQL collection and tables collation (with a base backup) are utf8_general_ci both... and all esperanto, japanese or arabic characters (utf8 encoded as I copy/past from wikipedia) are accepted without error.

May I had done the 1.4 upgrade with utf8 conversion on my PC (with a backup of base) and forgot to do it on the server? It can be Possible... Can I "re-upgrade" to 1.4, doing a utf8 conversion ?

Nevertheless, the ticket can be closed, sorry!

#25 Re: General support (1.4) » Last post (viewforum.php) not seen as last in main page (index.php) » 2010-09-23 18:58:55

Gil

OK, I have the same error with arabic or japanese characters... So it's not an "esperanto" problem, but a personal upgrade one; good for fluxbb wink, but bad luck for me sad

arabic: ة سهلة، اخترعها لودفيغ أليعزر زامنهوف کمشروع لغة

japanese: エスペラント

Pages: 1 2 3 4 Next

Board footer

Powered by FluxBB 1.4.8