Forums

Unfortunately no one can be told what FluxBB is - you have to see it for yourself.

You are not logged in.

#26 Re: Feature requests » Content-based CSS classes » 2010-08-19 21:33:16

Paul

You can have fancy images if you want.

.pun .postfootleft p span {background-image: offline.png}
.pun .postfootleft p strong {background-image: online.png}

On the general point of markup/css, that rather depends on what the future plans are.  If those plans include a template system then the issue becomes irrelevant as the markup and css will be whatever they need to be for each particular theme.

#27 Re: General support (1.4) » Moved and Closed text with Air theme » 2010-07-21 16:29:57

Paul

I disagree. That fact that a topic is closed is important.  The fact it is moved is less so.

#28 Re: Core development » Template system » 2010-07-03 12:07:01

Paul

I think I would probably go for helper functions to generate form fields not only because they are tedious to write particularly in admin but because it reduces the chance of errors and inconsistency creeping in.  Provided its done right there really is no good reason why anybody would want to tinker with the markup for the individual fields anyway.  Of course, its quite possible to load helper functions which are template specific for anybody who is desperate to tweak things.

A more important thing that has to be decided is how to handle language strings.  Either the controllers can merge the data and language string and then send it complete to the template which is what happens now or the language strings can be assigned to the template and the merging done on output.  The second way is cleaner but it means the templates will need to use printf() or a method which is a wrapper for printf().

Personally I think the principle should be that the controllers never generate markup, only data.  Markup is the responsibility of the view layer either being created in the templates or via template helpers.

#29 Re: Core development » 2.0 vs 1.x » 2010-07-01 21:18:44

Paul

I don't see the problem at all.  When the data is retrieved from the temp tables it is simply posted to the permanent tables as if it had just been submitted by a form. If its a reply the temp table would also have to store the id of the existing topic, if a topic then a new topic will simply be created exactly as if it were being posted directly.  The problem with adding a reviewed column is that you then have to alter all the display queries to deal with who has permissions to view posts/topics awaiting review etc.  My idea was something that could be bolted onto the existing system with minimal coding and no overhead.

NB: when I said viewtopic, what I meant was post.php.  I don't know why I said viewtopic because it doesn't need altering at all as I would envisage quick reply being hidden if post moderation was in effect.

Franz:  I see you've been doing a little stirring at PunBB.

#30 Re: Core development » 2.0 vs 1.x » 2010-07-01 19:44:38

Paul

Here is another idea that has been on the agenda for sometime, post approval i.e. posts don't appear in a thread until approved by mods or admins.

I did come up with a very simple way to implement this sometime ago.  Basically you create tables which are identical in structure to the tables which hold post and topic data; call them temp_posts and temp_topics.  When somebody posts whose posts need moderating then the posts go to the new temp_ tables.  This requires one new update query in viewtopic which is an exact duplicate of the existing query save for the table names.  The contents of posts held in the temp tables will then be displayed in admin on a page similar to the moderate topic page.  When posts are approved the data will be retrieved from the temp tables and posted to the public post and topic tables as if the post was being made there and then.

The beauty of doing it this way is that posts awaiting moderation don't have to be hidden because they are not included in the public tables to begin with.  As a result, no alteration of existing queries is required to deal with permissions and the code changes are all in admin save for a trivial adjustment to viewtopic.

#31 Re: Core development » 2.0 vs 1.x » 2010-07-01 19:31:02

Paul
Franz wrote:

And Paul, can you start a new topic showing off your template class? I'm interested to see it. Is it "just" a simple template wrapper or does it have built-in things like output escaping, too? I guess we can obviously all help with refactoring all the pages.

Well I was thinking more along the lines of "here it is, use it if you want" rather than starting a discussion.  At the moment I haven't implemented output escaping because I've taken the view that security matters should be dealt with by controllers and everything should have been made safe long before it gets anywhere near the templates.

If you want escaping built in then it can be done when data is assigned to the template object or it can be done when data is output.  Either way its very easy to implement.

#32 Re: General support (1.4) » RTL Stylesheets on GIT » 2010-07-01 18:30:00

Paul

Updated to FluxBB 1.4 Final and includes an Opera 10.6 fix which is shortly to be included in FluxBB itself.  Also inclues a bug fix for Chrome.

#33 Re: General discussion » Tiny Change - Need help! » 2010-07-01 10:52:28

Paul

You can try this.

For the last post column, find this

.brd .main-content .main-item li.info-lastpost cite,
.brd .main-content .main-item li.info-lastpost span,
.brd .main-content .main-item li.info-forum a {
    display: block;
    padding: 0 1em;
    font-style: normal;
    font-weight: normal;
    }

.brd .main-content .main-item li.info-lastpost strong {
    padding: 0 0 0 1em;
    font-style: normal;
    font-weight: normal;
    }

Replace with this

.brd .main-content .main-item li.info-forum a {
    display: block;
    padding: 0 1em;
    font-style: normal;
    font-weight: normal;
    }

.brd .main-content .main-item li.info-lastpost cite,
.brd .main-content .main-item li.info-lastpost span,
.brd .main-content .main-item li.info-lastpost strong {
    padding: 0 0 0 1em;
    font-style: normal;
    font-weight: normal;
    }

For the item subject add this

.brd .main-category .item-subject h3, .brd .main-category .item-subject p {
display: inline;
}

#34 Re: General support (1.4) » Why auto-increment for idx in index.php ? » 2010-06-30 11:49:04

Paul

Lets say you wanted a space between each category. The easiest way would be to apply a top margin or padding to each category and then set it to zero for the first category.  There are other ways of doing it but as a general rule whenever you have repeated items its useful to be able to pick out the first item.  Of course, if it weren't for IE6 there you could do it with css selectors alone.

#35 Re: General support (1.4) » Why auto-increment for idx in index.php ? » 2010-06-29 20:32:48

Paul

Moved. Not a bug, just an opinion.

The reason for the auto increment is to be able to identify the first visible category. However, the id could be replaced by the category name and a class inserted on the first category instead.  A class on the last category would also be useful but that requires a query to count categories.  Easy to do once there is a template system because an array is being produced instead of markup but not worth the effort at the moment.

#36 Re: General support (1.4) » Redirect time » 2010-06-26 22:05:44

Paul
Reines wrote:

If it's 0 then you don't see the redirect message, so it maybe isn't obvious that whatever you were doing succeeded or not.

That is exactly the reason.  In some cases it doesn't matter e.g. when posting a message, its obvious because a new post appears.  This is something Rickard had on his personal list to change at some point though I'm not sure what he had in mind, presumably some sort of immediate feedback on the active page.

#37 Re: Core development » 2.0 vs 1.x » 2010-06-19 21:05:46

Paul
Reines wrote:

Edit: I mean it's just a suggestion, we would maybe want to edit the original post to be clearer to avoid needing to read 2 pages worth of ideas.

That was my point.

#38 Re: Core development » 2.0 vs 1.x » 2010-06-19 15:57:48

Paul

Would it not be better to start a new public thread and keep it on topic since parts of this thread are developers jabber jabber.

#39 Re: Core development » T-3 » 2010-06-18 23:02:34

Paul

The easy way to spot things like that is to use a file compare tool like winmerge to spot a structural setting relating to widths which is in Technetium but not in Oxygen.  In this case it immediatelly showed up .pun {width: 95%} which needed to be reversed for the redirect pages.

#41 Re: Core development » Disallow INS in signature???? » 2010-06-18 20:46:32

Paul

As far as the img tag in posts is concerned the alt attribute is a must as it is required to satisfy accessibility guidelines and accessibility takes priority over just about everything else.  However, given that most poeple are not going to use it properly anyway the ideal would be an option to enable/disable with the default being disabled.  That way those who are concerned about accessibility can choose to enable it.  What you can't do it just get rid of it completely.

#42 Re: FluxBB discussion » SpinkBB for 1.3? » 2010-06-14 22:53:42

Paul

I misread, I thought it said 1.4. I'd forgotten 1.3 even existed.

#43 Re: Core development » T-3 » 2010-06-14 20:37:44

Paul

OK. It will take me a few minutes to do Earth and Fire but Oxygen etc might take a little longer.

EDIT: Earth and Fire now updated.

#44 Re: FluxBB discussion » SpinkBB for 1.3? » 2010-06-14 20:28:40

Paul

No is the short answer.

#45 Re: Core development » T-3 » 2010-06-14 20:27:31

Paul

Done. Can somebody test it.  I've only done Air for the moment but I can fix the other styles just in case if you wish.

#46 Re: Core development » T-3 » 2010-06-13 12:41:52

Paul

The problem with the userlist page, as you may have already worked out, is twofold.  First, all other paginated pages have breadcrumbs; second, the pagination placement is inconsistent with all the other pages.  The only effective way to make it work consistently is to add a breadcrumb and move the pagination to the top left as with all other paginated pages.

#47 Re: Core development » T-3 » 2010-06-13 12:17:44

Paul

The footer thing is just changing the the id name.  I will do that now.

#48 Re: Core development » T-3 » 2010-06-12 16:33:29

Paul

I hadn't noticed there was a release date.  Somebody also needs to revert userlist to how it was before.

#49 Re: Core development » Tiny website display issues, FF 3.6, OS X » 2010-06-09 21:17:24

Paul

Dont trouble yourself, I've totally rewritten it.

#50 Re: Core development » jQuery/Mootools/none for mods » 2010-06-09 10:55:18

Paul

I would have thought jQuery was the obvious choice as it seems to be becoming the defacto standard.

Board footer

Powered by FluxBB 1.4.8