You are not logged in.
- Topics: Active | Unanswered
#976 Re: General support (1.4) » Automatic mark subject as read » 2010-11-02 12:24:05
- Franz
Here come the instructions:
1. Open search.php
2. Find line 294
$result = $db->query('SELECT t.id FROM '.$db->prefix.'topics AS t LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=t.forum_id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND t.last_post>'.$pun_user['last_visit'].' AND t.moved_to IS NULL'.(isset($_GET['fid']) ? ' AND t.forum_id='.intval($_GET['fid']) : '').' ORDER BY t.last_post DESC') or error('Unable to fetch topic list', __FILE__, __LINE__, $db->error());3. Replace with
$result = $db->query('SELECT t.id, t.forum_id FROM '.$db->prefix.'topics AS t LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=t.forum_id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND t.last_post>'.$pun_user['last_visit'].' AND t.moved_to IS NULL'.(isset($_GET['fid']) ? ' AND t.forum_id='.intval($_GET['fid']) : '').' ORDER BY t.last_post DESC') or error('Unable to fetch topic list', __FILE__, __LINE__, $db->error());4. Find line 347
while ($row = $db->fetch_row($result))
$search_ids[] = $row[0];Replace with
while ($row = $db->fetch_row($result))
{
if ($action == 'show_new')
{
$t_t = get_tracked_topics();
if (!isset($t_t['topics'][$row[0]]) && !isset($t_t['forums'][$row[1]]))
$search_ids[] = $row[0];
}
else
$search_ids[] = $row[0];
}And then tell me if it works, please 
Note, though, that you have to click on the "Show new posts" link every time again - you cannot go back and refresh the search results page (these are cached).
#977 Re: General support (1.4) » Automatic mark subject as read » 2010-11-01 21:29:48
- Franz
Subjects have already differents icon color, so it dosen't really help.
Well, yes, that's what I was referring to. So that's not enough?
Users thinks there must be a difference between "New post" and "Recent post", so when then click on "Show news message since last visit", recent post that have already been read may not appear.
There is a difference. "New posts" shows all the new posts since the last time the user visited the board. "Recent posts" shows all posts made in the last 24 hours.
As I said, I'll try and look into it tomorrow and post instructions on how to change this (well, if nobody else does).
#978 Re: General support (1.4) » Automatic mark subject as read » 2010-11-01 20:18:45
- Franz
Does it help that all these topics have a different color once you read them?
If not, I'll try and post a patch tomorrow?
(That is, if you know how to apply a patch; if not, I'll just give you step-by-step instructions.)
#979 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-11-01 19:52:32
- Franz
I'm a bit unsure, if there's too much text at the right side in picture 2, that's why I made picture 3.
Dunno. I think it's fine. Would like to hear some more feedback on this, though, since you have a point.
Beside of that, in 1.3 these links were only on the index site... (If we decide to also show them on viewforum now, it would be awesome to let them only list new/active/unanswered topics in the particular forum)
I'd leave them there. The point of including them was having them (and they can be pretty helpful especially when browsing quickly through all active threads) available at all times; with them randomly appearing and disappearing I feel this would harm usability.
Having them on a per-forum basis seems like a nice idea, but I don't want to delay 1.4.3 too much, so I'd suggest thinking about it for 1.4.4, if that sounds ok?
Did you notice, that I put the breadcrumb on the index site?
Yup.
With the link texts a little shorter, would it maybe be possible to add the links on the left side of the "Post new topic" link. That way we would not have to add an extra breadcrumbs line on index.php.
#980 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-11-01 18:03:59
- Franz
Looks good to me. But what is the third picture about (besides not having the quick search links)?
With the link texts a little shorter, would it maybe be possible to add the links on the left side of the "Post new topic" link. That way we would not have to add an extra breadcrumbs line on index.php.
EDIT: Whoops, we'd still need a place for the links on the index page. I guess that idea is fine then.
Could you do that styling stuff for me? I feel scared when thinking about touching that stuff 
#981 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-11-01 09:47:40
- Franz
The top placement of the search links makes sense and I would also place the 'mark forum as read' link right under the subscribe to forum link.
In theory, the mark as read links may not be used a lot, but we should keep them for forums wih a visit timeout greater than 30 mins.
Then what about the link for marking all forums as read (index page)? I could just add a new line in that same position, but don't know whether that's a good idea...
Oh, and next to the subscription link or beneath it?
What did you do with the 'show unanswered posts' link?
It's there... "Unanswered topics" now.
#982 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-10-31 23:49:35
- Franz
Excellent idea.
Almost every page looks like this (the only thing that changes or disappears is the "mark as read" link):
And an example of profile.php (display obviously depends on permissions, but this looks very similar even if you can edit - admins and profile owners have one more link to view subscriptions):
#983 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-10-31 23:34:46
- Franz
Funny you should say that. Exactly 30 seconds before your post I made that link be displayed only on the index page.
If nobody else chimes in, I think we will leave them. The only question is where.
#984 Re: General support (1.4) » Unable to view own profile » 2010-10-31 22:32:50
- Franz
I don't quite understand your problem. Could you explain in more detail?
Everybody gets to see the overview page. Exceptions are administrators and the user to whom the profile belongs, because they can edit what other people can only read.
#985 Re: FluxBB discussion » Integrate FluxBB 1.4 with a WordPress site Part 1 - Design integration » 2010-10-31 20:15:30
- Franz
Not sure what you mean. I'm more than happy to help you on IRC, though.
As an alternative, you could of course post a link to that site.
#986 Re: Modifications (1.4) » Simple mark as solved » 2010-10-31 18:38:41
- Franz
Is it just me or is this code very prone to SQL injection? You need to escape user-contributed values (like those from $_GET) before using them in a query.
#987 Re: General support (1.4) » Unable to view own profile » 2010-10-31 15:24:42
- Franz
Well, yes, that's how it's supposed to be.
Of course you only see a part of the profile for other people. When you view your profile, you are viewing the real thing. You're only getting a limited peek at other users.
There's no overview page on your own profile, because you get that information on the "Essentials" page or other pages.
#988 Re: General support (1.4) » Unable to view own profile » 2010-10-31 14:21:23
- Franz
Hard to tell just guessing.
Do you have any modifications installed?
#989 Re: General discussion » a JSON-flatfile forum project, goobbs » 2010-10-31 08:24:25
- Franz
Interesting idea.
Do you really want to store the data in PHP files? I think that is just calling for exploits. Even if you add security measures so that nobody can put code in there, it is much safer to just leave it at *.dat or add *.txt instead.
#990 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-10-30 21:10:53
- Franz
Sure. I definitely like the idea for viewforum.php, though I am not perfectly sure about the link for "Mark all topics as read". Partially because I now display that link on any other page than viewforum.php (where online users are not displayed) - should that be reversed (it would be an easy fix)? On the other hand, though, and this is where I really am not sure, is whether this would be such a good spot usability-wise. Just not an expert in this area, but my gut doesn't like that position Basically, we're moving many links up to the header bar so that they are easier to reach and then move other links to some new (somewhat hidden) places. And yet, I want to get them out of the status bar, because it would just get too crowded (especially here 
).
Now for somebody doing the styling for me
#991 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-10-30 20:20:13
- Franz
The only odd thing I notice is where is the Mark this forum as read when viewing a forum?
I will check the viewforum links.
Great catch. I fixed the syntax error now.
#992 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-10-30 19:57:45
- Franz
Thanks for the feedback.
I'd honestly like the "Mark as read" links to be somewhere else entirely. I just don't know where
I don't have a preference regarding the order, but I assume that is entirely dependent on whether to include the "Mark as read" links or not.
Somebody will have to do the styling, but aligning the links to the right side is still planned.
show_recent is indeed new. I "copied" that directly from v1.3, but the old links (in all cases) will still work.
I will check the viewforum links.
#993 Re: Core development » Pull Request "#27: Reorganized quick searches" » 2010-10-30 15:49:06
- Franz
Good point. Thanks, Bert.
There is a big download button on http://github.com/lie2815/fluxbb/tree/2 … t-searches. You can then click on the "Download .zip" button in the new window to get the most recent branch source.
#995 Re: Feature requests » "Show all posts" must show posts » 2010-10-28 15:13:37
- Franz
This might help you:
http://help.github.com/pull-requests/#m … ll_request
#996 Re: Core development » 1.4.x Roadmap » 2010-10-28 12:28:20
- Franz
I was already working on those anyway as part of ticket #27. Technically, they weren't part of that ticket, though, so I added two new ones to document the changes (and have a complete list of changes in the release announcement later).
So that's why they were added. Don't worry. We're closing in on the release.
#997 Re: Modifications (1.4) » FluxBB styles » 2010-10-28 07:02:28
- Franz
Could you post screenshots so that we can see how exactly they are different from the styles "Mercury" and "Cobalt" which are still distributed in new releases.
#998 Re: Feature requests » "Show all posts" must show posts » 2010-10-27 22:09:44
- Franz
Ok, I pretty much finished everything.
Save for some styling issues this is good to go: http://github.com/fluxbb/fluxbb/pull/2
#999 Re: Feature requests » "Show all posts" must show posts » 2010-10-27 14:51:04
- Franz
I meant more of another position on the index page (or the forum page for "mark this forum as read" respectively).
Also: Should quick searches (or rather some of them: "unanswered topics" and "active topics" be available for guests, too?)
#1000 FluxBB discussion » Quick jump on index » 2010-10-27 14:19:59
- Franz
- Replies: 6
As part of the restructuring and reordering of quicklinks, I am moving around almost all links in the header and footer (well, that's a slight exaggeration).
As part of this, and also to provide for improved consistency and usability, I want to display the forum quick jump dropdown list on almost all pages.
The only page I'm not sure about is the index page, as all forums are available much easier through the forum list there. But still: Shall I just leave it there for consistency's sake?