Topic: Selected item in navlinks

Will be in FluxBB 1.4 class="active" on selected list item in navigation links at top of page like in 1.3?

Sorry for my English ;p
Polish FluxBB support

Re: Selected item in navlinks

I was wondering about this too smile There is class="isactive" but its only used on Profile and Admin menus.

Could this be added to the navigation links in the core also? Good for usability I think

Re: Selected item in navlinks

Added in changeset 1351.

Re: Selected item in navlinks

It looks to me on that setup that index is only active if you are on the index page.  Shouldn't index be the active link for any page that descends from it and doesn't have its own menu item, basically any page with breadcrumbs.  If not then if you are on viewforum or viewtopic there is no active menu item.  Either there is always an active item or never an active item.

An alternative way of doing it would be
define('FORUM_ACTIVE_PAGE', 'whatever')
And then used the same value on descendant pages e.g. index, viewforum and viewtopic would all have been 'index' and all profile pages would simply be 'profile' as would sub-forms such as change password, avatar upload etc.

The only thing worse than finding a bug is knowing I created it in the first place.

Re: Selected item in navlinks

Your way is much better. Changed in 1353. Thanks.

Re: Selected item in navlinks

Why did you use FORUM prefix instead of PUN?

Sorry for my English ;p
Polish FluxBB support

Re: Selected item in navlinks

Changed in 1356. Thanks.

Re: Selected item in navlinks

There is no reason to use PUN_ for a new constant. We already have a mix of PUN_* and FORUM_* constants (some new ones in v1.4), so there is absolutely no need to use a pointless prefix like PUN_ on FluxBB wink

http://www.fluxbb.de - Deutschsprachiges FluxBB-Supportforum

Re: Selected item in navlinks

But please don't change it back again.

The only thing worse than finding a bug is knowing I created it in the first place.

Re: Selected item in navlinks

Haha, I won't. I was just slightly confused about that discussion wink

http://www.fluxbb.de - Deutschsprachiges FluxBB-Supportforum