FluxBB Forums / Selected item in navlinks

Re: Selected item in navlinks

dummy@example.com (Franz) — Mon, 08 Feb 2010 12:16:16 +0000

Haha, I won't. I was just slightly confused about that discussion

Re: Selected item in navlinks

dummy@example.com (Paul) — Sun, 07 Feb 2010 19:00:18 +0000

But please don't change it back again.

Re: Selected item in navlinks

dummy@example.com (Franz) — Sun, 07 Feb 2010 18:31:11 +0000

There is no reason to use PUN_ for a new constant. We already have a mix of PUN_* and FORUM_* constants (some new ones in v1.4), so there is absolutely no need to use a pointless prefix like PUN_ on FluxBB

Re: Selected item in navlinks

dummy@example.com (quy) — Sun, 07 Feb 2010 16:05:08 +0000

Changed in 1356. Thanks.

Re: Selected item in navlinks

dummy@example.com (daris) — Sun, 07 Feb 2010 09:07:49 +0000

Why did you use FORUM prefix instead of PUN?

Re: Selected item in navlinks

dummy@example.com (quy) — Sun, 07 Feb 2010 02:41:02 +0000

Your way is much better. Changed in 1353. Thanks.

Re: Selected item in navlinks

dummy@example.com (Paul) — Sat, 06 Feb 2010 23:50:27 +0000

It looks to me on that setup that index is only active if you are on the index page. Shouldn't index be the active link for any page that descends from it and doesn't have its own menu item, basically any page with breadcrumbs. If not then if you are on viewforum or viewtopic there is no active menu item. Either there is always an active item or never an active item.

An alternative way of doing it would be
define('FORUM_ACTIVE_PAGE', 'whatever')
And then used the same value on descendant pages e.g. index, viewforum and viewtopic would all have been 'index' and all profile pages would simply be 'profile' as would sub-forms such as change password, avatar upload etc.

Re: Selected item in navlinks

dummy@example.com (quy) — Sat, 06 Feb 2010 23:25:07 +0000

Added in changeset 1351.

Re: Selected item in navlinks

dummy@example.com (orkneywd) — Sat, 06 Feb 2010 14:21:27 +0000

I was wondering about this too There is class="isactive" but its only used on Profile and Admin menus.

Could this be added to the navigation links in the core also? Good for usability I think

Selected item in navlinks

dummy@example.com (daris) — Wed, 03 Feb 2010 15:32:30 +0000

Will be in FluxBB 1.4 class="active" on selected list item in navigation links at top of page like in 1.3?